1247697 - Robocop SecurityExceptions in recent Try uplift simulations (Requires DISABLE_KEYGUARD permission)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Ran into this when running uplift simulations on Try, but Nick says that's probably not directly the culprit.

https://treeherder.mozilla.org/logviewer.html#?job_id=16624529&repo=try

 10:50:33  WARNING -  PROCESS-CRASH | java-exception | java.lang.SecurityException: Requires DISABLE_KEYGUARD permission at android.os.Parcel.readException(Parcel.java:1431)
 10:50:33     INFO -  0 ERROR runApp() exited with code 1
 10:50:33     INFO -  Unable to retrieve log file (/storage/sdcard/tests/logs/mochitest.log) from remote device
 10:50:33     INFO -  1 ERROR Automation Error: Exception caught while running tests
 10:50:33     INFO -  Traceback (most recent call last):
 10:50:33     INFO -    File "/builds/slave/test/build/tests/mochitest/runrobocop.py", line 456, in runSingleTest
 10:50:33     INFO -      log_result = self.parseLocalLog()
 10:50:33     INFO -    File "/builds/slave/test/build/tests/mochitest/runrobocop.py", line 271, in parseLocalLog
 10:50:33     INFO -      with open(self.localLog) as currentLog:
 10:50:33     INFO -  IOError: [Errno 2] No such file or directory: 'robocop.log'

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Any news here? I'm still seeing this in all of my Trunk-as-Aurora uplift simulations and we're about a week away from the next merge.

Comment 2

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

Attachment: MozReview Request: Bug 1247697 - Use Instrumentation context to disable keyguard and take wakelock; ignore SecurityExceptions. r?RyanVM

Review commit: https://reviewboard.mozilla.org/r/37175/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/37175/

Comment 3

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

RyanVM: could you try this out?  I pushed a try build here but the proof is in your uplift simulation.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=631a8ab4d62a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8724834 [details]
MozReview Request: Bug 1247697 - Use Instrumentation context to disable keyguard and take wakelock; ignore SecurityExceptions. r?RyanVM

Not a peer for the code, but can confirm that this fixes it!

Comment 5

[Geoff Brown [:gbrown]]

Comment on attachment 8724834 [details]
MozReview Request: Bug 1247697 - Use Instrumentation context to disable keyguard and take wakelock; ignore SecurityExceptions. r?RyanVM

https://reviewboard.mozilla.org/r/37175/#review34149

Why did this only show up in uplift simulations?

Comment 6

[Nick Alexander :nalexander [he/him] (PTO Feb 24-March 3)]

(In reply to Geoff Brown [:gbrown] from comment #5)
> Comment on attachment 8724834 [details]
> MozReview Request: Bug 1247697 - Use Instrumentation context to disable
> keyguard and take wakelock; ignore SecurityExceptions. r?RyanVM
> 
> https://reviewboard.mozilla.org/r/37175/#review34149
> 
> Why did this only show up in uplift simulations?

No idea.  I think perhaps we give permissions (to Robocop?) in Nightly?

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/97dc860fe618

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/97dc860fe618