1247724 - [FlyWeb] Update popover UI to conform to existing styles

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Justin D'Arcangelo [:justindarc]]

The current popover UI for FlyWeb is just a rough draft for getting things working. The UI should conform to the existing look & feel of the rest of similar toolbars in Firefox Desktop.

Comment 1

[Justin D'Arcangelo [:justindarc]]

I opened this bug to track landing of a patch I already built. Assigning to myself.

Comment 2

[Justin D'Arcangelo [:justindarc]]

Attachment: bug1247724.patch

Comment 3

[Kannan Vijayan [:djvj]]

Comment on attachment 8720991 [details] [diff] [review]
bug1247724.patch

Review of attachment 8720991 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Just minor nits in review comments.  R+.

::: browser/components/customizableui/CustomizableWidgets.jsm
@@ +1201,5 @@
>          this.discoveryManager.connectToService(serviceId, {
> +          connectSucceeded(connectedService) {
> +            let {hostname} = connectedService;
> +            let url = "http://" + hostname + "/";
> +            log.debug("CONNECT TO: ", url);

Nit: Cleaner log message here would be nice.

e.g.:
("FlyWeb connecting to: ", url)

::: browser/components/customizableui/content/panelUI.inc.xul
@@ +313,5 @@
>          <button id="PanelUI-panic-view-button"
>                  label="&panicButton.view.forgetButton;"/>
>        </vbox>
>      </panelview>
>   

Nit: not your problem, but it's right next to your code.  Whitespace on blank line.

Comment 4

[Justin D'Arcangelo [:justindarc]]

https://hg.mozilla.org/projects/larch/rev/bc7fdd4df1f68f367ffb887a12e5fe54bc2c91ed
Bug 1247724 - [FlyWeb] Update popover UI to conform to existing styles;r=djvj

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on larch:
http://hg.mozilla.org/projects/larch/rev/bc7fdd4df1f6