Closed Bug 1247763 Opened 5 years ago Closed 5 years ago

Remove info file parsing from GMP child process

Categories

(Core :: Audio/Video: GMP, defect)

Product:
Core
Component:
Audio/Video: GMP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

Details

Attachments

(1 file)

Patch: Remove GMP info parsing from GMP child process
10.24 KB, patch
gerald
: review+
Details | Diff | Splinter Review 
We only need to parse the GMP info file in the child process in order to determine what WMF libs to preload. We can however extract that info in the parent process, and send it over to the child process out of band to remove the need to parse the info file in the child process.
Now info file parsing happens only in the parent process.
Attachment #8719006 - Flags: review?(gsquelart)
Attachment #8719006 - Flags: review?(gsquelart) → review+
Comment on attachment 8719006 [details] [diff] [review]
Patch: Remove GMP info parsing from GMP child process

Review of attachment 8719006 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/gmp/GMPParent.cpp
@@ +778,5 @@
>    }
>  
> +#ifdef XP_WIN
> +  // "Libs" field is optional.
> +  ReadInfoField(parser, NS_LITERAL_CSTRING("libs"), mLibs);

"libraries", not "libs". d'oh!
https://hg.mozilla.org/mozilla-central/rev/c8f8ffd1c0c0
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.