1247763 - Remove info file parsing from GMP child process

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We only need to parse the GMP info file in the child process in order to determine what WMF libs to preload. We can however extract that info in the parent process, and send it over to the child process out of band to remove the need to parse the info file in the child process.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee78847cf5bb

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch: Remove GMP info parsing from GMP child process

Now info file parsing happens only in the parent process.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6208d3661f59

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8719006 [details] [diff] [review]
Patch: Remove GMP info parsing from GMP child process

Review of attachment 8719006 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/gmp/GMPParent.cpp
@@ +778,5 @@
>    }
>  
> +#ifdef XP_WIN
> +  // "Libs" field is optional.
> +  ReadInfoField(parser, NS_LITERAL_CSTRING("libs"), mLibs);

"libraries", not "libs". d'oh!

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=29e957b2a177

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8f8ffd1c0c0c0b502fce43f790cdbbcb90693e4
Bug 1247763 - Remove info file parsing from GMP child process. r=gerald

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c8f8ffd1c0c0