Closed Bug 1247764 Opened 4 years ago Closed 4 years ago

WebGL conformance 1.0.2 failure in context/context-attributes-alpha-depth-stencil-antialias.html

Categories

(Core :: Canvas: WebGL, defect)

Unspecified
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

Attachments

(2 files)

This fails on OSX+Intel, at least on my MBP force-restricted to Intel.
At some point it'd be nice to clean up this heavily-inlined function into something lighter-weight.
Attachment #8718568 - Flags: review?(jmuizelaar)
Attachment #8718569 - Flags: review?(jmuizelaar)
See Also: → 922875
Blocks: 922875
See Also: 922875
Attachment #8718569 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8718568 [details] [diff] [review]
0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch

Review of attachment 8718568 [details] [diff] [review]:
-----------------------------------------------------------------

Will this be visible to web content?
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Comment on attachment 8718568 [details] [diff] [review]
> 0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch
> 
> Review of attachment 8718568 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Will this be visible to web content?

No, it only swaps out the state for the draw call.

The test shows how the bug is currently visible to web content. After the fix, content will have no way to know we're doing this.

Was your concern about invisible overhead?
Comment on attachment 8718568 [details] [diff] [review]
0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch

Review of attachment 8718568 [details] [diff] [review]:
-----------------------------------------------------------------

Does this need a "Don't work around driver bugs part?"
Attachment #8718568 - Flags: review?(jmuizelaar) → review+
(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Comment on attachment 8718568 [details] [diff] [review]
> 0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch
> 
> Review of attachment 8718568 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this need a "Don't work around driver bugs part?"

What do you mean?
Flags: needinfo?(jmuizelaar)
if (WorkAroundDriverBugs())
Flags: needinfo?(jmuizelaar)
https://hg.mozilla.org/mozilla-central/rev/e8546267c973
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(In reply to Jeff Muizelaar [:jrmuizel] from comment #8)
> if (WorkAroundDriverBugs())

Yeah, I can add this.
Flags: needinfo?(jgilbert)
Flags: needinfo?(jgilbert)
You need to log in before you can comment on or make changes to this bug.