1247764 - WebGL conformance 1.0.2 failure in context/context-attributes-alpha-depth-stencil-antialias.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

This fails on OSX+Intel, at least on my MBP force-restricted to Intel.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch

At some point it'd be nice to clean up this heavily-inlined function into something lighter-weight.

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: 0002-Add-a-test.patch

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8718568 [details] [diff] [review]
0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch

Review of attachment 8718568 [details] [diff] [review]:
-----------------------------------------------------------------

Will this be visible to web content?

Comment 4

[Kelsey Gilbert [:jgilbert]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Comment on attachment 8718568 [details] [diff] [review]
> 0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch
> 
> Review of attachment 8718568 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Will this be visible to web content?

No, it only swaps out the state for the draw call.

The test shows how the bug is currently visible to web content. After the fix, content will have no way to know we're doing this.

Was your concern about invisible overhead?

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8718568 [details] [diff] [review]
0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch

Review of attachment 8718568 [details] [diff] [review]:
-----------------------------------------------------------------

Does this need a "Don't work around driver bugs part?"

Comment 6

[Kelsey Gilbert [:jgilbert]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #5)
> Comment on attachment 8718568 [details] [diff] [review]
> 0001-Disable-STENCIL_TEST-on-mac-intel-when-drawing-with-.patch
> 
> Review of attachment 8718568 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does this need a "Don't work around driver bugs part?"

What do you mean?

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e8546267c973

Comment 8

[Jeff Muizelaar [:jrmuizel]]

if (WorkAroundDriverBugs())

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e8546267c973

Comment 10

[Kelsey Gilbert [:jgilbert]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #8)
> if (WorkAroundDriverBugs())

Yeah, I can add this.