1247800 - Need to investigate why transform or opacity animations in invisible elements run both on main-thread and compositor on Android

Status: RESOLVED FIXED

Description

[Hiroyuki Ikezoe (:hiro)]

I notice this fast in bug 1235286 comment 16 first.  We should investigate it in further detail.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

As of 2016/02/12 JST:

In scrolled out elements:
 * transform animations
  * keep running on compositor
  * consume almost half of frames (6 or 7 / 10 frames) for restyling

 * opacity animations
  * keep running on compositor
  * consume almost half of frames (6 or 7 / 10 frames) for restyling

In visibility:hidden elements:
 * transform animations
  * keep running on compositor
  * sometimes consume the first two or three frames for restyling

 * opacity animations
  * keep running on compositor
  * sometimes consume the first two or three frames for restyling

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Today I noticed opacity animations in visibility:hidden elements do not consume compositor thread at all.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99675e2fe2a8
I've never checked which changeset fixed it, but we should enable a test in test_restyle.html as soon as possible.
Note that transform animations in visibility:hidden elements still consume compositor thread.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Created attachment 8755283 [details]
Bug 1247800 - Run skipped test cases on Android.

Review commit: https://reviewboard.mozilla.org/r/54512/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/54512/

Comment 4

[Brian Birtles (:birtles)]

Comment on attachment 8755283 [details]
Bug 1247800 - Run skipped test cases on Android.

https://reviewboard.mozilla.org/r/54512/#review51136

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/36afeff56b61

Comment 6

[Hiroyuki Ikezoe (:hiro)]

For my own references,  IIRC, we built nsDisplayOpacity/nsDisplayTransform in visibility:hidden elements both on desktop and Android before.  But now it seems that nsDisplayTransform in visibility:hidden is built only on Android. In all other cases display items are no longer built.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/36afeff56b61

Comment 8

[Hiroyuki Ikezoe (:hiro)]

I will revisit this after we enabled stylo on Android.

Comment 9

[Hiroyuki Ikezoe (:hiro)]

test_restyles.html is getting more robust than before due to bug 1379515, bug 1421476, etc.

So I did push a try with enabling skipped test cases;

https://treeherder.mozilla.org/#/jobs?repo=try&revision=781d317e0e04415b5bfabadf06f79d165eaa442d

Yeah, the result looks pretty good.  Now it's the time to run the skipped test cases on Android too.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8755283 [details]
Bug 1247800 - Run skipped test cases on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54512/diff/1-2/

Comment 11

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8755283 [details]
Bug 1247800 - Run skipped test cases on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/54512/diff/2-3/

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Hmm, we can't reuse this bug for the new patch, the new patch marked as if it got already r+.  I will open a new bug.

Comment 13

[Hiroyuki Ikezoe (:hiro)]

Closing since bug 1427868 has been fixed.

Comment 14

[Firefox Product Integrity Bug Husbandry Bot (contact :emceeaich)]

Removing leave-open keyword from resolved bugs, per :sylvestre.