Closed
Bug 1247854
Opened 9 years ago
Closed 9 years ago
Scrolling with mousewheel is broken in some situations
Categories
(Core :: Panning and Zooming, defect, P1)
Tracking
()
VERIFIED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox44 | --- | unaffected |
firefox45 | --- | unaffected |
firefox46 | + | fixed |
firefox47 | + | verified |
firefox48 | --- | verified |
People
(Reporter: julienw, Assigned: mstange)
References
Details
(Keywords: regression, Whiteboard: gfx-noted)
Attachments
(3 files)
6.33 KB,
text/html
|
Details | |
3.38 KB,
patch
|
Details | Diff | Splinter Review | |
58 bytes,
text/x-review-board-request
|
mattwoodrow
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details |
[Tracking Requested - why for this release]:
STR:
1. Go to https://www.paris-web.fr/association/membres.php
2. put your mouse on a non empty space
3. Try to scroll using the mousewheel (or anything similar like the trackpad scroll -- on Linux at least)
=> It doesn't work at all.
This works when doing the same gesture on the blue background on the left or the right of the page.
This also works when the page is in "mobile" mode (you can press ctrl + + repeatidly to enter this mode, or enter responsive mode).
Reproducing in Aurora 46 and Nightly 47 (Build ID: 20160211030242).
NOT reproducing in Beta 45 and Stable 44.
Nothing looks unusual in this page's CSS. The obvious difference between the mobile and desktop versions of the site is the use of a "float" in the desktop version.
Reporter | ||
Updated•9 years ago
|
Version: 44 Branch → 46 Branch
Reporter | ||
Updated•9 years ago
|
Component: Untriaged → Panning and Zooming
Keywords: regression,
regressionwindow-wanted
![]() |
||
Comment 1•9 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2ec54b38a33da939a8255612999d9e867eb11664&tochange=bb5becd378f40a9be14e4e635d7034f2835fc7b5
Via local build
Last Good: db3a7c3208e7
First Bad: 7d23d87b02f8
Updated•9 years ago
|
Blocks: apz-desktop
![]() |
||
Comment 4•9 years ago
|
||
Updated•9 years ago
|
Whiteboard: gfx-noted
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mstange
Flags: needinfo?(mstange)
Comment 6•9 years ago
|
||
This is a P1 blocking APZ rollout since we're generally recommending Keith's pure-CSS parallax approach as being APZ-friendly and it's currently broken because of this bug.
Priority: -- → P1
Assignee | ||
Comment 7•9 years ago
|
||
Assignee | ||
Comment 8•9 years ago
|
||
I've decided to fix this in a very explicit way. The only "magic" part that's
left is how we decide that the AGR of the perspective item is outside the
scrolled frame (and I'm not sure myself how that works).
I didn't want to change what scroll clips we set on what items, because the
scroll clip really belongs on the perspective item, because that's the item
that needs to be clipped, and it should also be the item that should be
scrolled if it weren't for the fact that APZ wouldn't know that it should
apply the perspective transform before the APZ transform.
Review commit: https://reviewboard.mozilla.org/r/36833/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36833/
Attachment #8724047 -
Flags: review?(matt.woodrow)
Assignee | ||
Comment 9•9 years ago
|
||
Comment 10•9 years ago
|
||
Comment on attachment 8724047 [details]
MozReview Request: Bug 1247854 - Apply the correct scroll clips to the nsDisplayTransform and nsDisplayPerspective of a scrolled perspective item. r?mattwoodrow
https://reviewboard.mozilla.org/r/36833/#review33773
Attachment #8724047 -
Flags: review?(matt.woodrow) → review+
Comment 11•9 years ago
|
||
Tracking, regression.
Markus, once this lands, want to request uplift?
tracking-firefox47:
--- → +
Assignee | ||
Comment 12•9 years ago
|
||
Yes, absolutely, this needs to be uplifted once it lands. It's currently waiting for the patches in bug 1238564 to be reviewed and landed.
Comment 13•9 years ago
|
||
Updated•9 years ago
|
Blocks: apz-desktop-blockers
Updated•9 years ago
|
No longer blocks: all-aboard-apz
Comment 14•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Assignee | ||
Comment 15•9 years ago
|
||
Comment on attachment 8724047 [details]
MozReview Request: Bug 1247854 - Apply the correct scroll clips to the nsDisplayTransform and nsDisplayPerspective of a scrolled perspective item. r?mattwoodrow
Approval Request Comment
[Feature/regressing bug #]: APZ / bug 1147673
[User impact if declined]: scrolling impossible on some pages, and a certain parallax technique won't work properly
[Describe test coverage new/current, TreeHerder]: this patch adds a test
[Risks and why]: low
[String/UUID change made/needed]: none
This patch requires the changes in bug 1238564.
Attachment #8724047 -
Flags: approval-mozilla-beta?
Attachment #8724047 -
Flags: approval-mozilla-aurora?
Comment 16•9 years ago
|
||
kats says we'll want this fix for the APZ experiment on Beta 46.
Comment on attachment 8724047 [details]
MozReview Request: Bug 1247854 - Apply the correct scroll clips to the nsDisplayTransform and nsDisplayPerspective of a scrolled perspective item. r?mattwoodrow
This sounds like a must fix, has been in Nightly for a week, taking it. Aurora47+, Beta46+
Attachment #8724047 -
Flags: approval-mozilla-beta?
Attachment #8724047 -
Flags: approval-mozilla-beta+
Attachment #8724047 -
Flags: approval-mozilla-aurora?
Attachment #8724047 -
Flags: approval-mozilla-aurora+
Julien, could you please verify this issue is fixed as expected on the latest Nightly build (03-10-2016 build on wards has the fix)? Thanks!
Flags: needinfo?(felash)
Reporter | ||
Comment 19•9 years ago
|
||
Yes this is fixed on Nightly :)
Thanks for the hard work !
Flags: needinfo?(felash)
Comment 20•9 years ago
|
||
has conflicts uplifting to aurora:
grafting 332726:e0b2fffc1360 "Bug 1247854 - Apply the correct scroll clips to the nsDisplayTransform and nsDisplayPerspective of a scrolled perspective item. r=mattwoodrow"
merging layout/base/FrameLayerBuilder.cpp
merging layout/reftests/async-scrolling/reftest.list
warning: conflicts while merging layout/base/FrameLayerBuilder.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging layout/reftests/async-scrolling/reftest.list! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)
Flags: needinfo?(mstange)
Assignee | ||
Comment 21•9 years ago
|
||
This patch requires the patches in bug 1238564. We can't uplift it until those patches are also uplifted.
Flags: needinfo?(mstange)
Comment 22•9 years ago
|
||
Ritu, could you please also approve bug 1238564 for uplift?
Flags: needinfo?(rkothari)
Comment 23•9 years ago
|
||
wes, can you try to land this again after landing the uplifts in bug 1238564? Thanks!
Flags: needinfo?(wkocher)
Liz and I chatted about the risks involved in uplifting bug 1238564. The fix was deemed must-have for 46 and 47. She A+'d in the other bug.
Flags: needinfo?(rkothari)
Comment 25•9 years ago
|
||
Comment 26•9 years ago
|
||
has problems uplifting to beta:
merging layout/base/FrameLayerBuilder.cpp
merging layout/base/FrameLayerBuilder.h
merging layout/reftests/async-scrolling/reftest.list
warning: conflicts while merging layout/base/FrameLayerBuilder.cpp! (edit, then use 'hg resolve --mark')
warning: conflicts while merging layout/reftests/async-scrolling/reftest.list! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)
Flags: needinfo?(mstange)
Comment 27•9 years ago
|
||
bugherder uplift |
Flags: needinfo?(wkocher)
Assignee | ||
Updated•9 years ago
|
Flags: needinfo?(mstange)
Comment 28•9 years ago
|
||
Verified as fixed using Firefox 47 beta 1 (with e10s enabled) and latest Aurora 48.0a2.
You need to log in
before you can comment on or make changes to this bug.
Description
•