1247913 - Update releaserunner to treeherder-client 2.0.1

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Ed Morley [:emorley]]

releaserunner is still using 1.7.0:
https://hg.mozilla.org/build/puppet/file/2075e856e7b8/modules/releaserunner/manifests/init.pp#l57

Comment 1

[Ed Morley [:emorley]]

Attachment: Update releaserunner to treeherder-client 2.0.1

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8718801 [details] [diff] [review]
Update releaserunner to treeherder-client 2.0.1

remote:   https://hg.mozilla.org/build/puppet/rev/6047dbc02d16
remote:   https://hg.mozilla.org/build/puppet/rev/fb8a4b40af09

Comment 3

[Rail Aliiev [:rail]]

Thank you for the patch!

Comment 4

[Jordan Lund (:jlund)]

I think this broke releaserunner:

Traceback (most recent call last):
  File "release-runner.py", line 19, in <module>
    from releasetasks import make_task_graph
  File "/home/cltbld/releasetasks/releasetasks/__init__.py", line 9, in <module>
    from thclient import TreeherderClient
  File "/builds/releaserunner/lib/python2.7/site-packages/thclient/__init__.py", line 1, in <module>
    from .client import *
  File "/builds/releaserunner/lib/python2.7/site-packages/thclient/client.py", line 8, in <module>
    from requests_hawk import HawkAuth
ImportError: No module named requests_hawk

Comment 5

[Jordan Lund (:jlund)]

I can look into this tomorrow but I think we will need to add a bit more reqs: https://github.com/sydvicious/mozplatformqa-jenkins/pull/13/files#diff-b4ef698db8ca845e5845c4618278f29aR15

iiuc - these will need to be put in our puppet python repo first: http://puppetagain.pub.build.mozilla.org/data/python/packages/

Comment 6

[Ed Morley [:emorley]]

Ah sorry about that.

I'd skimmed the list of packages in the puppet file and since http2lib (one of the old deps) wasn't listed, had presumed the puppet config wasn't specifying sub-dependencies. (It actually appears to me missing some sub-dependencies - I'd recommend turning on --no-deps, or even better using pip v8's hash checking feature which does that and more).

The deps had been uploaded to http://pypi.pub.build.mozilla.org/pub/ in bug 1236965, so I thought that they'd be available - but it looks like http://puppetagain.pub.build.mozilla.org/data/python/packages/ is a separate thing. Not sure why we have two mirrors?

The following files will need to be uploaded to the puppetagain mirror:

http://pypi.pub.build.mozilla.org/pub/requests-2.9.1-py2.py3-none-any.whl
http://pypi.pub.build.mozilla.org/pub/requests-2.9.1.tar.gz

http://pypi.pub.build.mozilla.org/pub/requests_hawk-1.0.0-py2.py3-none-any.whl
http://pypi.pub.build.mozilla.org/pub/requests-hawk-1.0.0.tar.gz

http://pypi.pub.build.mozilla.org/pub/six-1.10.0-py2.py3-none-any.whl
http://pypi.pub.build.mozilla.org/pub/six-1.10.0.tar.gz

http://pypi.pub.build.mozilla.org/pub/treeherder_client-2.0.1-py2-none-any.whl
(the treeherder-client sdist has already been uploaded)

http://pypi.pub.build.mozilla.org/pub/mohawk-0.3.0.tar.gz
(mohawk doesn't have a wheel available)

I'll put together a patch for the puppet config to add the additional dependencies explicitly.

Comment 7

[Ed Morley [:emorley]]

Attachment: Explicitly list treeherder-client dependencies

This patch lists the treeherder-client dependencies explicitly.

I've left the six/requests dependencies as-is for the moment, since treeherder-client doesn't need the newest versions and I know taskcluster has some unfortunate dependency on an old version of requests.

As such, just the following need uploading to the puppetagain mirror:

http://pypi.pub.build.mozilla.org/pub/mohawk-0.3.0.tar.gz
http://pypi.pub.build.mozilla.org/pub/requests_hawk-1.0.0-py2.py3-none-any.whl
http://pypi.pub.build.mozilla.org/pub/requests-hawk-1.0.0.tar.gz

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8720223 [details] [diff] [review]
Explicitly list treeherder-client dependencies

remote:   https://hg.mozilla.org/build/puppet/rev/182338f37252
remote:   https://hg.mozilla.org/build/puppet/rev/b42829a2a95a

Comment 9

[Rail Aliiev [:rail]]

FTR, I uploaded mohawk 0.3.1 to match the manifest.

Comment 10

[Ed Morley [:emorley]]

(In reply to Rail Aliiev [:rail] from comment #9)
> FTR, I uploaded mohawk 0.3.1 to match the manifest.

Thank you - sorry missed that.