Remove tabs' visibleLabel property and TabLabelModified event, backing out bug 943820

RESOLVED FIXED in Firefox 47

Status

()

Firefox
Tabbed Browser
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: dao, Assigned: dao)

Tracking

(Blocks: 1 bug, {addon-compat})

Trunk
Firefox 47
addon-compat
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Created attachment 8718806 [details] [diff] [review]
patch

Bug 943820 was done in preparation for bug 583890 and then that bug got dropped. This is just useless overhead at this point. We should add this stuff back only if and when bug 583890 becomes a thing again.
Attachment #8718806 - Flags: review?(gijskruitbosch+bugs)

Comment 1

a year ago
I'm sure this is a dumb question, but why not just drive the patch from bug 583890 over the line?
Flags: needinfo?(dao)
(Assignee)

Comment 2

a year ago
Well, because that's no easy task. It wasn't just dropped over laziness. AFAIK there were UX issues and maybe implementation problems too and generally it's just not a priority for anyone anymore. But bug 943820 is easy to reinstate when that becomes necessary, regardless of whether that's tomorrow or in two years (if ever).
Flags: needinfo?(dao)

Comment 3

a year ago
Comment on attachment 8718806 [details] [diff] [review]
patch

Review of attachment 8718806 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the backout, but note that there is add-on impact. I haven't assessed how significant that will be, but both visibleLabel and TabLabelModified do have hits in the add-on MXR, though some of the visibleLabel ones are not for the tabs.
Attachment #8718806 - Flags: review?(gijskruitbosch+bugs) → review+
(Assignee)

Updated

a year ago
Keywords: addon-compat

Comment 4

a year ago
https://hg.mozilla.org/integration/fx-team/rev/ef33e22149d2
https://hg.mozilla.org/mozilla-central/rev/ef33e22149d2
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.