Closed Bug 1247920 Opened 5 years ago Closed 5 years ago

Remove tabs' visibleLabel property and TabLabelModified event, backing out bug 943820

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 47
Tracking Status
firefox47 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Keywords: addon-compat)

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 943820 was done in preparation for bug 583890 and then that bug got dropped. This is just useless overhead at this point. We should add this stuff back only if and when bug 583890 becomes a thing again.
Attachment #8718806 - Flags: review?(gijskruitbosch+bugs)
I'm sure this is a dumb question, but why not just drive the patch from bug 583890 over the line?
Flags: needinfo?(dao)
Well, because that's no easy task. It wasn't just dropped over laziness. AFAIK there were UX issues and maybe implementation problems too and generally it's just not a priority for anyone anymore. But bug 943820 is easy to reinstate when that becomes necessary, regardless of whether that's tomorrow or in two years (if ever).
Flags: needinfo?(dao)
Comment on attachment 8718806 [details] [diff] [review]
patch

Review of attachment 8718806 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the backout, but note that there is add-on impact. I haven't assessed how significant that will be, but both visibleLabel and TabLabelModified do have hits in the add-on MXR, though some of the visibleLabel ones are not for the tabs.
Attachment #8718806 - Flags: review?(gijskruitbosch+bugs) → review+
Keywords: addon-compat
https://hg.mozilla.org/mozilla-central/rev/ef33e22149d2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
You need to log in before you can comment on or make changes to this bug.