1247920 - Remove tabs' visibleLabel property and TabLabelModified event, backing out bug 943820

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Bug 943820 was done in preparation for bug 583890 and then that bug got dropped. This is just useless overhead at this point. We should add this stuff back only if and when bug 583890 becomes a thing again.

Comment 1

[:Gijs (he/him)]

I'm sure this is a dumb question, but why not just drive the patch from bug 583890 over the line?

Comment 2

[Dão Gottwald [:dao]]

Well, because that's no easy task. It wasn't just dropped over laziness. AFAIK there were UX issues and maybe implementation problems too and generally it's just not a priority for anyone anymore. But bug 943820 is easy to reinstate when that becomes necessary, regardless of whether that's tomorrow or in two years (if ever).

Comment 3

[:Gijs (he/him)]

Comment on attachment 8718806 [details] [diff] [review]
patch

Review of attachment 8718806 [details] [diff] [review]:
-----------------------------------------------------------------

r=me for the backout, but note that there is add-on impact. I haven't assessed how significant that will be, but both visibleLabel and TabLabelModified do have hits in the add-on MXR, though some of the visibleLabel ones are not for the tabs.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ef33e22149d2

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ef33e22149d2