Closed
Bug 1247978
Opened 8 years ago
Closed 8 years ago
Ensure minidump header is written first
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: snorp, Unassigned)
Details
Attachments
(1 file)
2.13 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We have some reports like this one[0] where the dump seems largely intact, but there is no header. On Linux it seems the header is only written at the end of a successful dump, so if we crash during the dump (as we appear to be doing), we have an unusable minidump. [0] https://crash-stats.mozilla.com/report/index/cef5b777-02d1-43c2-bf40-133ab2160209
Reporter | ||
Comment 1•8 years ago
|
||
Attachment #8718905 -
Flags: review?(ted)
Reporter | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2069ffa73784
Comment 3•8 years ago
|
||
Comment on attachment 8718905 [details] [diff] [review] Ensure minidump header gets written during crash dump on Linux Review of attachment 8718905 [details] [diff] [review]: ----------------------------------------------------------------- I checked and this builds and passes the Breakpad unit tests. Submitted upstream: https://codereview.chromium.org/1696573003
Attachment #8718905 -
Flags: review?(ted) → review+
Comment 4•8 years ago
|
||
Landed upstream: https://chromium.googlesource.com/breakpad/breakpad/+/e5adfac03b410520a5ffc4a1adab570445d34e30
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/22d3b72e28e4
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•