Closed Bug 1247978 Opened 5 years ago Closed 5 years ago

Ensure minidump header is written first

Categories

(Toolkit :: Crash Reporting, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: snorp, Unassigned)

Details

Attachments

(1 file)

We have some reports like this one[0] where the dump seems largely intact, but there is no header. On Linux it seems the header is only written at the end of a successful dump, so if we crash during the dump (as we appear to be doing), we have an unusable minidump.

[0] https://crash-stats.mozilla.com/report/index/cef5b777-02d1-43c2-bf40-133ab2160209
Comment on attachment 8718905 [details] [diff] [review]
Ensure minidump header gets written during crash dump on Linux

Review of attachment 8718905 [details] [diff] [review]:
-----------------------------------------------------------------

I checked and this builds and passes the Breakpad unit tests.

Submitted upstream:
https://codereview.chromium.org/1696573003
Attachment #8718905 - Flags: review?(ted) → review+
https://hg.mozilla.org/mozilla-central/rev/22d3b72e28e4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.