Remove mobile/android/defs.mk

RESOLVED FIXED in Firefox 47

Status

defect
RESOLVED FIXED
3 years ago
Last year

People

(Reporter: nalexander, Assigned: nalexander)

Tracking

(Blocks 1 bug)

unspecified
mozilla47
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(3 attachments)

Attachment #8719219 - Flags: review?(ted)
Attachment #8719220 - Flags: review?(ted)
Attachment #8719221 - Flags: review?(ted)
ted: did these review requests actually make it to you?  I was trying to spread the build peer load but I'm happy to get it into somebody else's queue.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Flags: needinfo?(ted)
Apparently but I just didn't look at them! Sorry.
Flags: needinfo?(ted)
Attachment #8719219 - Flags: review?(ted) → review+
Comment on attachment 8719219 [details]
MozReview Request: Bug 1248160 - Part 1: Remove MOZ_ANDROID_SHARED_ACCOUNT_TYPE. r?ted.mielczarek

https://reviewboard.mozilla.org/r/34907/#review32479

I love patches with nothing but code removal!
Comment on attachment 8719220 [details]
MozReview Request: Bug 1248160 - Part 2: Inline MOZ_ANDROID_SHARED_FXACCOUNT_TYPE. r?ted.mielczarek

https://reviewboard.mozilla.org/r/34909/#review32481
Attachment #8719220 - Flags: review?(ted) → review+
Comment on attachment 8719221 [details]
MozReview Request: Bug 1248160 - Part 3: Move MOZ_ANDROID_SHARED_ID to branding; remove mobile/android/defs.mk. r?ted.mielczarek

https://reviewboard.mozilla.org/r/34911/#review32483

Nice work!

::: configure.in:8674
(Diff revision 1)
> +   MOZ_ANDROID_SHARED_ID="$ANDROID_PACKAGE_NAME.sharedID"

nit: I'd make this `${ANDROID_PACKAGE_NAME}.sharedID` for clarity.
Attachment #8719221 - Flags: review?(ted) → review+

Comment 10

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/66be41482fd4
https://hg.mozilla.org/mozilla-central/rev/8c4b08c0d438
https://hg.mozilla.org/mozilla-central/rev/7d4147c08c3e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.