Closed
Bug 1248160
Opened 5 years ago
Closed 5 years ago
Remove mobile/android/defs.mk
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
|
Assignee | |
Comment 1•5 years ago
|
||
This is cleaning up after Bug 1220906, which removed Old Sync. Review commit: https://reviewboard.mozilla.org/r/34907/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34907/
|
|
Assignee | |
Comment 2•5 years ago
|
||
This is per-package, so there's no cross-package definition needed. Review commit: https://reviewboard.mozilla.org/r/34909/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34909/
|
|
Assignee | |
Comment 3•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/34911/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/34911/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8719219 -
Flags: review?(ted)
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8719220 -
Flags: review?(ted)
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8719221 -
Flags: review?(ted)
|
|
Assignee | |
Comment 4•5 years ago
|
||
ted: did these review requests actually make it to you? I was trying to spread the build peer load but I'm happy to get it into somebody else's queue.
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Flags: needinfo?(ted)
|
||
Updated•5 years ago
|
Attachment #8719219 -
Flags: review?(ted) → review+
|
|
||
Comment 6•5 years ago
|
||
Comment on attachment 8719219 [details] MozReview Request: Bug 1248160 - Part 1: Remove MOZ_ANDROID_SHARED_ACCOUNT_TYPE. r?ted.mielczarek https://reviewboard.mozilla.org/r/34907/#review32479 I love patches with nothing but code removal!
|
|
||
Comment 7•5 years ago
|
||
Comment on attachment 8719220 [details] MozReview Request: Bug 1248160 - Part 2: Inline MOZ_ANDROID_SHARED_FXACCOUNT_TYPE. r?ted.mielczarek https://reviewboard.mozilla.org/r/34909/#review32481
Attachment #8719220 -
Flags: review?(ted) → review+
|
|
||
Comment 8•5 years ago
|
||
Comment on attachment 8719221 [details] MozReview Request: Bug 1248160 - Part 3: Move MOZ_ANDROID_SHARED_ID to branding; remove mobile/android/defs.mk. r?ted.mielczarek https://reviewboard.mozilla.org/r/34911/#review32483 Nice work! ::: configure.in:8674 (Diff revision 1) > + MOZ_ANDROID_SHARED_ID="$ANDROID_PACKAGE_NAME.sharedID" nit: I'd make this `${ANDROID_PACKAGE_NAME}.sharedID` for clarity.
Attachment #8719221 -
Flags: review?(ted) → review+
https://hg.mozilla.org/integration/fx-team/rev/66be41482fd4 https://hg.mozilla.org/integration/fx-team/rev/8c4b08c0d438 https://hg.mozilla.org/integration/fx-team/rev/7d4147c08c3e
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/66be41482fd4 https://hg.mozilla.org/mozilla-central/rev/8c4b08c0d438 https://hg.mozilla.org/mozilla-central/rev/7d4147c08c3e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•3 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•