1248197 - remove spdy/3.1 support

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Masatoshi Kimura [:emk]]

Chrome will drop the support on May 15th.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=12494301a0a9&selectedJob=16708768

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8719237 [details] [diff] [review]
patch

not yet.. there is still plenty of spdy usage

Comment 3

[Patrick McManus [:mcmanus]]

we will do this eventually, but not now. definitely on the radar

Comment 5

[u570621]

Chrome removed support for spdy/3.1. Only http/2 supported now. Firefox should do the same, irrelevant of how much spdy/3.1 usage there is. We don't want to be stuck having to support and maintain old spdy/3.1 code for long.

Comment 6

[Masatoshi Kimura [:emk]]

Reopening because :mcmanus suggested reconsidering (bug 1248198 comment #23).

Comment 7

[Patrick McManus [:mcmanus]]

we're down to ~2% spdy usage compared to 20% when this was filed. I think its ok to do in a ride the trains fashion now. NPN is a bit more complicated - it is used with h2, and it has implications for false start.. so let's make sure we deal with that as a separate topic.

nick - I think you've wanted this for a while. Would you do a patch for gecko-50 that flips the pref to off (the tests should set it on explicitly so they are probably ok - but make sure) and then a code removal patch for 51? The pref flip should be a different bug.

To whatever extent people want to rename remaining code things to h2 from spdy let's do that in a different patch. I'm agnostic on it.

thanks!

Comment 8

[u408661]

*insert high-pitched squeeing noise here*

I will absolutely take this. You're right, I've been itching to do this at *least* since Orlando, and even more since London, when I looked at the telemetry, too. Just forgot to bring it up :)

I'll file another bug for the pref-flip, and probably another one for renaming stuff away from spdy, as well.

Comment 9

[u408661]

Attachment: Bug 1248197 - Remove spdy/3.1 support.

Review commit: https://reviewboard.mozilla.org/r/67152/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/67152/

Comment 10

[u408661]

Comment 9 is the patch ready to go. Try run at https://treeherder.mozilla.org/#/jobs?repo=try&revision=91ebf7b76273

Patrick, feel free to review whenever, I won't land until the 51 cycle starts on Aug 5.

Comment 11

[Patrick McManus [:mcmanus]]

I guess this is good training for watching my kid leave the house and go off to the real world. bittersweet.

r+ for 51

Comment 12

[Patrick McManus [:mcmanus]]

Comment on attachment 8774707 [details]
Bug 1248197 - Remove spdy/3.1 support.

https://reviewboard.mozilla.org/r/67152/#review64070

Comment 13

[u408661]

Dunno why I typed Aug 5 - the 51 cycle has started as of yesterday!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea3d721baedc
Remove spdy/3.1 support. r=mcmanus

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ea3d721baedc