1248228 - Bug 1246756 broke BSD builds

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Landry Breuil (:gaston)]

14:37.24 In file included from /home/obj/buildslave/mozilla-central/gfx/skia/Unified_cpp_gfx_skia16.cpp:101:
14:37.24 /home/dusk/home/buildslave-amd64/mozilla-central-amd64/build/gfx/skia/skia/src/ports/SkOSFile_stdio.cpp:149:16: error: expected unqualified-id
14:37.26     int fd = ::fileno(f);
14:37.26                ^
14:37.26 /usr/include/stdio.h:426:20: note: expanded from macro 'fileno'
14:37.26 #define fileno(p)       (!__isthreaded ? __sfileno(p) : (fileno)(p))
14:37.26                          ^
14:37.28 In file included from /home/obj/buildslave/mozilla-central/gfx/skia/Unified_cpp_gfx_skia16.cpp:101:
14:37.30 /home/dusk/home/buildslave-amd64/mozilla-central-amd64/build/gfx/skia/skia/src/ports/SkOSFile_stdio.cpp:149:16: error: extraneous ')' before ';'
14:37.30 /usr/include/stdio.h:426:62: note: expanded from macro 'fileno'
14:37.32 #define fileno(p)       (!__isthreaded ? __sfileno(p) : (fileno)(p))

From http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/1637/steps/build/logs/stdio

Comment 1

[Landry Breuil (:gaston)]

Martin, jan, do you also see this ?

Comment 2

[Landry Breuil (:gaston)]

(I wont comment on the need of skia to reimplement/rewrap stdio functions.. sigh)

Comment 3

[Jan Beich]

Skia itself builds fine on FreeBSD 10+ but the headers maybe not safe to use, see bug 1248228.

OpenBSD (and DragonFly) issue in comment 0 is mainly lack of |#ifndef __cplusplus| guards around macros. Other BSD descendants have them.

https://github.com/android/platform_bionic/commit/f2cea021ab2c6d7d7feeb40cca098aa132605876
https://github.com/bitrig/bitrig/commit/1abd6adb31462edf8f2875e3d03ba8cd2af713df
https://github.com/jsonn/src/commit/d782c95120fdb70f3b8d74e5a183bfb0f98fc770
https://github.com/freebsd/freebsd/commit/dd1ce6fd6c2c0f0c70f3c78a4959185bb93eb1c3
https://github.com/unofficial-opensource-apple/Libc/tree/569b0a5190c89f8729c22e09fb15f6252feadcfc/include/stdio.h

Comment 4

[Jan Beich]

(In reply to Jan Beich from comment #3)
> Skia itself builds fine on FreeBSD 10+ but the headers maybe not safe to
> use, see bug 1248228.

Bug 1248416 of course.

Comment 5

[Lee Salzman [:lsalzman]]

Upstream bug report: https://bugs.chromium.org/p/skia/issues/detail?id=4953

Comment 6

[Lee Salzman [:lsalzman]]

Attachment: Build fix for SkOSFile_stdio on OpenBSD

This is just a backport of an already upstreamed fix: https://skia.googlesource.com/skia.git/+/944c2d901c5118abae2262f38414ccb939111355%5E!/

Comment 7

[Lee Salzman [:lsalzman]]

Try builds: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a441365141d

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a2d680cecc3

Comment 9

[Landry Breuil (:gaston)]

Great, thanks lee ! m-i builds fine here now without any patches.

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8a2d680cecc3