Closed Bug 1248228 Opened 6 years ago Closed 6 years ago

Bug 1246756 broke BSD builds

Categories

(Core :: Graphics, defect)

Unspecified
OpenBSD
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: gaston, Assigned: lsalzman)

References

Details

Attachments

(1 file)

14:37.24 In file included from /home/obj/buildslave/mozilla-central/gfx/skia/Unified_cpp_gfx_skia16.cpp:101:
14:37.24 /home/dusk/home/buildslave-amd64/mozilla-central-amd64/build/gfx/skia/skia/src/ports/SkOSFile_stdio.cpp:149:16: error: expected unqualified-id
14:37.26     int fd = ::fileno(f);
14:37.26                ^
14:37.26 /usr/include/stdio.h:426:20: note: expanded from macro 'fileno'
14:37.26 #define fileno(p)       (!__isthreaded ? __sfileno(p) : (fileno)(p))
14:37.26                          ^
14:37.28 In file included from /home/obj/buildslave/mozilla-central/gfx/skia/Unified_cpp_gfx_skia16.cpp:101:
14:37.30 /home/dusk/home/buildslave-amd64/mozilla-central-amd64/build/gfx/skia/skia/src/ports/SkOSFile_stdio.cpp:149:16: error: extraneous ')' before ';'
14:37.30 /usr/include/stdio.h:426:62: note: expanded from macro 'fileno'
14:37.32 #define fileno(p)       (!__isthreaded ? __sfileno(p) : (fileno)(p))

From http://buildbot.rhaalovely.net/builders/mozilla-central-amd64/builds/1637/steps/build/logs/stdio
Blocks: 1246756
Martin, jan, do you also see this ?
(I wont comment on the need of skia to reimplement/rewrap stdio functions.. sigh)
(In reply to Jan Beich from comment #3)
> Skia itself builds fine on FreeBSD 10+ but the headers maybe not safe to
> use, see bug 1248228.

Bug 1248416 of course.
This is just a backport of an already upstreamed fix: https://skia.googlesource.com/skia.git/+/944c2d901c5118abae2262f38414ccb939111355%5E!/
Assignee: nobody → lsalzman
Status: NEW → ASSIGNED
Attachment #8719812 - Flags: review?(jmuizelaar)
Attachment #8719812 - Flags: review?(jmuizelaar) → review+
Great, thanks lee ! m-i builds fine here now without any patches.
https://hg.mozilla.org/mozilla-central/rev/8a2d680cecc3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.