1248472 - (SQLite3.11.0) Upgrade to SQLite 3.11.0

Status: RESOLVED FIXED

(Toolkit :: Storage, defect)

Description

[NVD]

https://www.sqlite.org/news.html

https://www.sqlite.org/releaselog/3_11_0.html

SQLite version 3.11.0 is a regularly scheduled maintenance release.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5cb68e6db459

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade SQLite to version 3.11.0

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8723924 [details] [diff] [review]
Upgrade SQLite to version 3.11.0

No issues running it locally and looks good on Try.

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8723924 [details] [diff] [review]
Upgrade SQLite to version 3.11.0

Review of attachment 8723924 [details] [diff] [review]:
-----------------------------------------------------------------

thank you!

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/02a2962dcbec

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/02a2962dcbec

Comment 7

[D. Richard Hipp]

SQLite version 3.11.1 is out, but the only changes are in extensions that are not used by Firefox: FTS5 and spellfix1.  In my judgement, there is no need to upgrade.

Comment 8

[Jorg K (CEST = GMT+2)]

That broke Thunderbird. Looks like TB is using the FTS3_TOKENIZER which no longer seems to work. See bug 1252937 comment #5.

Comment 9

[D. Richard Hipp]

Legacy fts3_tokenzer() behavior can be restored by adding the -DSQLITE_ENABLE_FTS3_TOKENIZER compile-time option.  A run-time option will also be available in version 3.12.0.

Comment 10

[:aceman]

Where can we put that option? What is the build file for the internal sqlite? Could we put it into SQLITE_CFLAGS ? But that one is defined in old-configure which does not seem to be the right place.

Comment 11

[aleth [:aleth]]

Should the sqlite in nss/ be upgraded to match? (https://dxr.mozilla.org/mozilla-central/source/security/nss/lib/sqlite/sqlite3.h#114)

Comment 12

[Ryan VanderMeulen [:RyanVM]]

NSS updates are done upstream whenever they see fit. We don't use their copy of sqlite for building Firefox, anyway.

Comment 13

[Andrew Sutherland [:asuth] (he/him)]

(In reply to D. Richard Hipp from comment #9)
> Legacy fts3_tokenzer() behavior can be restored by adding the
> -DSQLITE_ENABLE_FTS3_TOKENIZER compile-time option.  A run-time option will
> also be available in version 3.12.0.

Global runtime or per-connection?  If we ignore linux distro builds with system SQLite, the compile-time option is probably easiest for mozStorage and Thunderbird.  If we factor in distro builds, the runtime option and requiring 3.12.0 is probably preferable but more work since it avoids configure checks and require the distro to build with the flag.

The most ideal thing might be if the tokenizer registration could be moved to be an explicit API call like sqlite3_vtab_config.  The Thunderbird registration is already in native code[1] because it has to get and bind a blob pointer, so it wouldn't be a major change. 

1: https://dxr.mozilla.org/comm-central/source/mailnews/extensions/fts3/src/nsFts3Tokenizer.cpp#33

Comment 14

[Andrew Sutherland [:asuth] (he/him)]

(In reply to :aceman from comment #10)
> Where can we put that option? What is the build file for the internal
> sqlite? Could we put it into SQLITE_CFLAGS ? But that one is defined in
> old-configure which does not seem to be the right place.

This question is moot, :aceman already provided a patch on bug 1252937.