1248493 - rework interfaces to webfont activation methods

Status: NEW

(Core :: Graphics: Text, defect, P3)

Description

[John Daggett (:jtd)]

The code for activating webfonts from data (MakePlatformFont) and from local fonts referenced by name (LookupLocalFont) create font entries but don't set the family name. This doesn't make a lot of sense.

Also, both methods exist as virtual methods in gfxPlatform *and* in gfxPlatformFontList. Until the gfxPangoFontGroup code is eliminated, this needs to continue but I think the methods can be consolidated so that the gfxPlatform versions of these methods would call through to the gfxPlatformFontList methods by default. There's no need for derived versions except in the gfxPlatformGTK case to support the old gfxPangoFontGroup code.

Comment 1

[Masatoshi Kimura [:emk]]

(In reply to John Daggett (:jtd) from comment #0)
> Also, both methods exist as virtual methods in gfxPlatform *and* in
> gfxPlatformFontList. Until the gfxPangoFontGroup code is eliminated, this
> needs to continue but I think the methods can be consolidated so that the
> gfxPlatform versions of these methods would call through to the
> gfxPlatformFontList methods by default. There's no need for derived versions
> except in the gfxPlatformGTK case to support the old gfxPangoFontGroup code.

I implemented this part in bug 1255973.