Closed Bug 1248499 Opened 5 years ago Closed 5 years ago

Implement tabs.detectLanguage

Categories

(WebExtensions :: Untriaged, defect, P3)

defect

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Iteration:
47.3 - Mar 7
Tracking Status
firefox47 --- fixed

People

(Reporter: kmag, Assigned: kmag)

References

Details

(Whiteboard: [tabs] triaged)

Attachments

(1 file)

No description provided.
Depends on: 1248501
Kris, did you want me to take this on along with bug 1246754, or do you think it's too complicated for me at this point?
I'd rather handle this one. There are a lot of moving parts.
Iteration: --- → 47.3 - Mar 7
Flags: blocking-webextensions+
Priority: -- → P3
Whiteboard: [tabs] → [tabs] triaged
Comment on attachment 8724210 [details]
MozReview Request: Bug 1248499: [webext] Implement tabs.detectLanguage. r?billm

https://reviewboard.mozilla.org/r/36919/#review33793

::: toolkit/components/extensions/ExtensionContent.jsm:819
(Diff revision 1)
> +      let text = encoder.encodeToString();

Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm?
Attachment #8724210 - Flags: review?(wmccloskey) → review+
https://reviewboard.mozilla.org/r/36919/#review33793

> Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm?

I guess. I was trying to avoid returning lower quality results than Chrome, if we can help it, but I don't really know if limiting it to 60K will make a difference anywhere.
https://hg.mozilla.org/mozilla-central/rev/0585ef0c9fe4
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.