Implement tabs.detectLanguage

RESOLVED FIXED in Firefox 47

Status

defect
P3
normal
RESOLVED FIXED
3 years ago
11 months ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

unspecified
mozilla47
Dependency tree / graph
Bug Flags:
blocking-webextensions +

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: [tabs] triaged)

Attachments

(1 attachment)

Assignee

Description

3 years ago
No description provided.
Assignee

Updated

3 years ago
Depends on: 1248501
Kris, did you want me to take this on along with bug 1246754, or do you think it's too complicated for me at this point?
Assignee

Comment 2

3 years ago
I'd rather handle this one. There are a lot of moving parts.
Assignee

Updated

3 years ago
Iteration: --- → 47.3 - Mar 7

Updated

3 years ago
Flags: blocking-webextensions+
Priority: -- → P3
Whiteboard: [tabs] → [tabs] triaged
Comment on attachment 8724210 [details]
MozReview Request: Bug 1248499: [webext] Implement tabs.detectLanguage. r?billm

https://reviewboard.mozilla.org/r/36919/#review33793

::: toolkit/components/extensions/ExtensionContent.jsm:819
(Diff revision 1)
> +      let text = encoder.encodeToString();

Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm?
Attachment #8724210 - Flags: review?(wmccloskey) → review+
Assignee

Comment 5

3 years ago
https://reviewboard.mozilla.org/r/36919/#review33793

> Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm?

I guess. I was trying to avoid returning lower quality results than Chrome, if we can help it, but I don't really know if limiting it to 60K will make a difference anywhere.

Comment 7

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0585ef0c9fe4
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Updated

11 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.