1248499 - Implement tabs.detectLanguage

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P3)

Comment 1

[Bob Silverberg [:bsilverberg]]

Kris, did you want me to take this on along with bug 1246754, or do you think it's too complicated for me at this point?

Comment 2

[Kris Maglione [:kmag]]

I'd rather handle this one. There are a lot of moving parts.

Comment 3

[Kris Maglione [:kmag]]

Attachment: MozReview Request: Bug 1248499: [webext] Implement tabs.detectLanguage. r?billm

Review commit: https://reviewboard.mozilla.org/r/36919/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/36919/

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8724210 [details]
MozReview Request: Bug 1248499: [webext] Implement tabs.detectLanguage. r?billm

https://reviewboard.mozilla.org/r/36919/#review33793

::: toolkit/components/extensions/ExtensionContent.jsm:819
(Diff revision 1)
> +      let text = encoder.encodeToString();

Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm?

Comment 5

[Kris Maglione [:kmag]]

https://reviewboard.mozilla.org/r/36919/#review33793

> Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm?

I guess. I was trying to avoid returning lower quality results than Chrome, if we can help it, but I don't really know if limiting it to 60K will make a difference anywhere.

Comment 6

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/fx-team/rev/0585ef0c9fe41b27e01b3be189aa869c3144ead3
Bug 1248499: [webext] Implement tabs.detectLanguage. r=billm

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0585ef0c9fe4