Closed
Bug 1248499
Opened 6 years ago
Closed 6 years ago
Implement tabs.detectLanguage
Categories
(WebExtensions :: Untriaged, defect, P3)
WebExtensions
Untriaged
Tracking
(firefox47 fixed)
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: kmag, Assigned: kmag)
References
Details
(Whiteboard: [tabs] triaged)
Attachments
(1 file)
No description provided.
Comment 1•6 years ago
|
||
Kris, did you want me to take this on along with bug 1246754, or do you think it's too complicated for me at this point?
Assignee | ||
Comment 2•6 years ago
|
||
I'd rather handle this one. There are a lot of moving parts.
Assignee | ||
Updated•6 years ago
|
Iteration: --- → 47.3 - Mar 7
Updated•6 years ago
|
Flags: blocking-webextensions+
Priority: -- → P3
Whiteboard: [tabs] → [tabs] triaged
Assignee | ||
Comment 3•6 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/36919/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36919/
Attachment #8724210 -
Flags: review?(wmccloskey)
Comment on attachment 8724210 [details] MozReview Request: Bug 1248499: [webext] Implement tabs.detectLanguage. r?billm https://reviewboard.mozilla.org/r/36919/#review33793 ::: toolkit/components/extensions/ExtensionContent.jsm:819 (Diff revision 1) > + let text = encoder.encodeToString(); Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm?
Attachment #8724210 -
Flags: review?(wmccloskey) → review+
Assignee | ||
Comment 5•6 years ago
|
||
https://reviewboard.mozilla.org/r/36919/#review33793 > Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm? I guess. I was trying to avoid returning lower quality results than Chrome, if we can help it, but I don't really know if limiting it to 60K will make a difference anywhere.
Assignee | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/0585ef0c9fe41b27e01b3be189aa869c3144ead3 Bug 1248499: [webext] Implement tabs.detectLanguage. r=billm
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0585ef0c9fe4
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Updated•4 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•