Closed Bug 1248499 Opened 5 years ago Closed 5 years ago
58 bytes, text/x-review-board-request
No description provided.
Kris, did you want me to take this on along with bug 1246754, or do you think it's too complicated for me at this point?
I'd rather handle this one. There are a lot of moving parts.
Priority: -- → P3
Whiteboard: [tabs] → [tabs] triaged
Review commit: https://reviewboard.mozilla.org/r/36919/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/36919/
Attachment #8724210 - Flags: review?(wmccloskey)
Comment on attachment 8724210 [details] MozReview Request: Bug 1248499: [webext] Implement tabs.detectLanguage. r?billm https://reviewboard.mozilla.org/r/36919/#review33793 ::: toolkit/components/extensions/ExtensionContent.jsm:819 (Diff revision 1) > + let text = encoder.encodeToString(); Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm?
Attachment #8724210 - Flags: review?(wmccloskey) → review+
https://reviewboard.mozilla.org/r/36919/#review33793 > Could we limit the sample to 60KB like we do in TranslationContentHandler.jsm? I guess. I was trying to avoid returning lower quality results than Chrome, if we can help it, but I don't really know if limiting it to 60K will make a difference anywhere.
https://hg.mozilla.org/integration/fx-team/rev/0585ef0c9fe41b27e01b3be189aa869c3144ead3 Bug 1248499: [webext] Implement tabs.detectLanguage. r=billm
You need to log in before you can comment on or make changes to this bug.