Remove nsDocument::IsFullScreenDoc() in favor of checking GetFullscreenElement directly

RESOLVED FIXED in Firefox 47

Status

()

defect
RESOLVED FIXED
3 years ago
2 months ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 fixed)

Details

(Whiteboard: dom-triaged btpp-active)

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Per bug 743198 comment 47:
> It is a bit misleading to use different method in JS than in C++ to check whether we're in fullscreen.

We could remove nsDocument::IsFullScreenDoc() and just use GetFullscreenElement everywhere directly.
Xidorn, I put backlog here but feel free to make this "btpp-active" or "btpp-fixlater" :)
Whiteboard: dom-triaged btpp-backlog
(Assignee)

Comment 2

3 years ago
Posted patch patchSplinter Review
Assignee: nobody → quanxunzhen
Attachment #8722387 - Flags: review?(bugs)
(Assignee)

Updated

3 years ago
Whiteboard: dom-triaged btpp-backlog → dom-triaged btpp-active
Attachment #8722387 - Flags: review?(bugs) → review+

Comment 4

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c8be68703225
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.