Closed
Bug 1248505
Opened 9 years ago
Closed 9 years ago
Remove nsDocument::IsFullScreenDoc() in favor of checking GetFullscreenElement directly
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
(Whiteboard: dom-triaged btpp-active)
Attachments
(1 file)
|
13.87 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Per bug 743198 comment 47:
> It is a bit misleading to use different method in JS than in C++ to check whether we're in fullscreen.
We could remove nsDocument::IsFullScreenDoc() and just use GetFullscreenElement everywhere directly.
|
||
Comment 1•9 years ago
|
||
Xidorn, I put backlog here but feel free to make this "btpp-active" or "btpp-fixlater" :)
Whiteboard: dom-triaged btpp-backlog
|
Assignee | |
Comment 2•9 years ago
|
||
Assignee: nobody → quanxunzhen
Attachment #8722387 -
Flags: review?(bugs)
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: dom-triaged btpp-backlog → dom-triaged btpp-active
|
||
Updated•9 years ago
|
Attachment #8722387 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c8be68703225291c63a409516f7a36cdeb6aa314
Bug 1248505 - Remove nsDocument::IsFullScreenDoc and its uses. r=smaug
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•