Closed Bug 1248505 Opened 4 years ago Closed 4 years ago

Remove nsDocument::IsFullScreenDoc() in favor of checking GetFullscreenElement directly

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

(Whiteboard: dom-triaged btpp-active)

Attachments

(1 file)

patch
13.87 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
Per bug 743198 comment 47:
> It is a bit misleading to use different method in JS than in C++ to check whether we're in fullscreen.

We could remove nsDocument::IsFullScreenDoc() and just use GetFullscreenElement everywhere directly.
Xidorn, I put backlog here but feel free to make this "btpp-active" or "btpp-fixlater" :)
Whiteboard: dom-triaged btpp-backlog
Attached patch patch — — Splinter Review
Assignee: nobody → quanxunzhen
Attachment #8722387 - Flags: review?(bugs)
Whiteboard: dom-triaged btpp-backlog → dom-triaged btpp-active
Attachment #8722387 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c8be68703225
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.