Closed
Bug 1248558
Opened 8 years ago
Closed 8 years ago
[Static Analysis][Unintentional integer overflow][CacheFile.cpp::PreloadChunk, CacheFile.cpp::GetChunkLocked]
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: radu.stoica, Assigned: radu.stoica)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1213968)
Attachments
(1 file)
|
1.32 KB,
patch
|
michal
:
review+
|
Details | Diff | Splinter Review |
The Static Analysis tool Coverity added Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) overflow_before_widen: Potentially overflowing expression aIndex * 262144U with type unsigned int (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type int64_t (64 bits, signed).
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8719748 -
Flags: review?(mcmanus)
|
|
Assignee | |
Updated•8 years ago
|
Severity: normal → minor
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8719748 [details] [diff] [review] bug_1248558.diff Review of attachment 8719748 [details] [diff] [review]: ----------------------------------------------------------------- to honza..
Attachment #8719748 -
Flags: review?(mcmanus) → review?(honzab.moz)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8719748 [details] [diff] [review] bug_1248558.diff -> michal
Attachment #8719748 -
Flags: review?(honzab.moz) → review?(michal.novotny)
|
||
Updated•8 years ago
|
Attachment #8719748 -
Flags: review?(michal.novotny) → review+
|
||
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc71db9db3e5
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•