1248632 - Fix and re-enable browser_bug415846.js for e10s

Status: REOPENED

(Toolkit :: Safe Browsing, defect, P5)

Description

[Mike Conley (:mconley) (:⚙️)]

Was disabled in https://bugzilla.mozilla.org/show_bug.cgi?id=1246115#c17 due to frequent failures on our CI machines.

Comment 1

[Chris Peterson [:cpeterson]]

Gijs, this Safe Browsing test is disabled for e10s on all desktop platforms (and on Mac because of "its bizarre special-and-unique snowflake of a help menu"). How important is this test to fix for e10s?

Comment 2

[:Gijs (he/him)]

(In reply to Chris Peterson [:cpeterson] from comment #1)
> Gijs, this Safe Browsing test is disabled for e10s on all desktop platforms
> (and on Mac because of "its bizarre special-and-unique snowflake of a help
> menu"). How important is this test to fix for e10s?

So we broke this menu at some point both inside and outside e10s.

Then we fixed it in bug 1246115 - fixing it was deemed to track a release, so we clearly thought it was important. Then the automated test for this got disabled in e10s for almost-perma-failing on slow platforms.

It's hard to know for sure whether that means the test is losing a race (in e10s) or the code is losing a race and the test is exposing that, without diving deeper into the issue here. Considering we blocked on the regression, I think we should at least investigate which of those is happening here. If it's "just" the test, that's slightly less important, but if the code is racing in e10s and sometimes we show the wrong menu, that's definitely worrisome.

Comment 3

[Chris Peterson [:cpeterson]]

Thanks. Sending this bug back to e10s triage to be prioritized.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Gijs, are there any logs of this test failing still around?

Comment 5

[:Gijs (he/him)]

From https://bugzilla.mozilla.org/show_bug.cgi?id=1246115#c17 linked in comment #0:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=8a3b953ac30f&group_state=expanded&filter-searchStr=e10s%20browser-chrome

http://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-inbound-linux-debug/1455338808/mozilla-inbound_ubuntu32_vm-debug_test-mochitest-e10s-browser-chrome-3-bm05-tests1-linux32-build131.txt.gz

21:16:39     INFO -  250 INFO *** Start BrowserChrome Test Results ***
21:16:39     INFO -  251 INFO checking window state
21:16:39     INFO -  252 INFO Entering test bound
21:16:39     INFO -  253 INFO TEST-PASS | browser/components/safebrowsing/content/test/browser_bug415846.js | Help menu should exist -
21:16:39     INFO -  254 INFO TEST-PASS | browser/components/safebrowsing/content/test/browser_bug415846.js | Report phishing menu item should exist -
21:16:39     INFO -  255 INFO TEST-PASS | browser/components/safebrowsing/content/test/browser_bug415846.js | Report phishing error menu item should exist -
21:16:39     INFO -  256 INFO TEST-PASS | browser/components/safebrowsing/content/test/browser_bug415846.js | Report phishing menu should be visible on normal sites -
21:16:39     INFO -  257 INFO TEST-PASS | browser/components/safebrowsing/content/test/browser_bug415846.js | Report error menu item should be hidden on normal sites -
21:16:39     INFO -  258 INFO Leaving test bound
21:16:39     INFO -  259 INFO Entering test bound
21:16:39     INFO -  260 INFO TEST-PASS | browser/components/safebrowsing/content/test/browser_bug415846.js | Help menu should exist -
21:16:39     INFO -  261 INFO TEST-PASS | browser/components/safebrowsing/content/test/browser_bug415846.js | Report phishing menu item should exist -
21:16:39     INFO -  262 INFO TEST-PASS | browser/components/safebrowsing/content/test/browser_bug415846.js | Report phishing error menu item should exist -
21:16:39     INFO -  263 INFO TEST-UNEXPECTED-FAIL | browser/components/safebrowsing/content/test/browser_bug415846.js | Report phishing menu should be hidden on phishing sites -
21:16:39     INFO -  Stack trace:
21:16:39     INFO -      chrome://mochitests/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js:null:80
21:16:39     INFO -      chrome://mochitests/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js:check_menu_at_page/<:53
21:16:39     INFO -      check_menu_at_page@chrome://mochitests/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js:26:10
21:16:39     INFO -      @chrome://mochitests/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js:79:9
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:319:40
21:16:39     INFO -      TaskImpl@resource://gre/modules/Task.jsm:280:3
21:16:39     INFO -      createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:254:14
21:16:39     INFO -      Task_spawn@resource://gre/modules/Task.jsm:168:12
21:16:39     INFO -      TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:388:16
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:327:13
21:16:39     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
21:16:39     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
21:16:39     INFO -      Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
21:16:39     INFO -      this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
21:16:39     INFO -      this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
21:16:39     INFO -      promise callback*this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:705:7
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:324:13
21:16:39     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
21:16:39     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
21:16:39     INFO -      Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
21:16:39     INFO -      this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
21:16:39     INFO -      this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:324:13
21:16:39     INFO -      promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:327:13
21:16:39     INFO -      promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:327:13
21:16:39     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
21:16:39     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
21:16:39     INFO -      Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
21:16:39     INFO -      this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
21:16:39     INFO -      this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
21:16:39     INFO -      receiveMessage@resource://testing-common/ContentTask.jsm:113:9
21:16:39     INFO -  Not taking screenshot here: see the one that was previously logged
21:16:39     INFO -  264 INFO TEST-UNEXPECTED-FAIL | browser/components/safebrowsing/content/test/browser_bug415846.js | Report error menu item should be visible on phishing sites -
21:16:39     INFO -  Stack trace:
21:16:39     INFO -      chrome://mochitests/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js:null:82
21:16:39     INFO -      chrome://mochitests/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js:check_menu_at_page/<:53
21:16:39     INFO -      check_menu_at_page@chrome://mochitests/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js:26:10
21:16:39     INFO -      @chrome://mochitests/content/browser/browser/components/safebrowsing/content/test/browser_bug415846.js:79:9
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:319:40
21:16:39     INFO -      TaskImpl@resource://gre/modules/Task.jsm:280:3
21:16:39     INFO -      createAsyncFunction/asyncFunction@resource://gre/modules/Task.jsm:254:14
21:16:39     INFO -      Task_spawn@resource://gre/modules/Task.jsm:168:12
21:16:39     INFO -      TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:388:16
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:327:13
21:16:39     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
21:16:39     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
21:16:39     INFO -      Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
21:16:39     INFO -      this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
21:16:39     INFO -      this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
21:16:39     INFO -      promise callback*this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:705:7
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:324:13
21:16:39     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
21:16:39     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
21:16:39     INFO -      Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
21:16:39     INFO -      this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
21:16:39     INFO -      this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:324:13
21:16:39     INFO -      promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:327:13
21:16:39     INFO -      promise callback*TaskImpl_handleResultValue@resource://gre/modules/Task.jsm:395:7
21:16:39     INFO -      TaskImpl_run@resource://gre/modules/Task.jsm:327:13
21:16:39     INFO -      Handler.prototype.process@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:937:23
21:16:39     INFO -      this.PromiseWalker.walkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:816:7
21:16:39     INFO -      Promise*this.PromiseWalker.scheduleWalkerLoop@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:747:11
21:16:39     INFO -      this.PromiseWalker.schedulePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:779:7
21:16:39     INFO -      this.PromiseWalker.completePromise@resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js:714:7
21:16:40     INFO -      receiveMessage@resource://testing-common/ContentTask.jsm:113:9
21:16:40     INFO -  265 INFO Leaving test bound
21:16:40     INFO -  MEMORY STAT vsizeMaxContiguous not supported in this build configuration.
21:16:40     INFO -  MEMORY STAT | vsize 765MB | residentFast 255MB | heapAllocated 88MB
21:16:40     INFO -  266 INFO TEST-OK | browser/components/safebrowsing/content/test/browser_bug415846.js | took 10621ms

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Hmm, there's nothing obvious wrong here and I can't reproduce the failure locally. I'm not too worried about this single test, though (especially because I can't reproduce the failure).

Comment 7

[Chris Peterson [:cpeterson]]

Thanks. I'll reprioritize this test bug so we revisit it after we ship e10s.

Comment 8

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.