1248734 - Fix SDK startup on Instanbird

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: sdk-instantbird-startup.patch

Add-on SDK extensions currently fail to load on startup on Instantbird (a comm-central application). This patch adds Instantbird as a detectable XUL app and gives it a custom observer topic to listen to on startup. Adding it to the detectable XUL apps is needed to have a custom observer topic.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8719938 [details] [diff] [review]
sdk-instantbird-startup.patch

Review of attachment 8719938 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the long waiting; Looks good to me. Maybe we should point what is "officially" supported, but I think at this point is not really necessary.

Comment 2

[Martin Giger [:freaktechnik]]

(In reply to Matteo Ferretti [:matteo][:zer0] from comment #1)
> Sorry for the long waiting; Looks good to me. Maybe we should point what is
> "officially" supported, but I think at this point is not really necessary.
Thabk you for the review! I think there's an MDN page somewhere touching on the subject of SDK extensions outside of Firefox. I'll look it up and extend it if it makes sense.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/02cf3a4bf42a

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/02cf3a4bf42a