Closed Bug 1248734 Opened 8 years ago Closed 8 years ago

Fix SDK startup on Instanbird

Categories

(Add-on SDK Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: freaktechnik, Unassigned)

Details

Attachments

(1 file)

Add-on SDK extensions currently fail to load on startup on Instantbird (a comm-central application). This patch adds Instantbird as a detectable XUL app and gives it a custom observer topic to listen to on startup. Adding it to the detectable XUL apps is needed to have a custom observer topic.
Attachment #8719938 - Flags: review?(zer0)
Comment on attachment 8719938 [details] [diff] [review]
sdk-instantbird-startup.patch

Review of attachment 8719938 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the long waiting; Looks good to me. Maybe we should point what is "officially" supported, but I think at this point is not really necessary.
Attachment #8719938 - Flags: review?(zer0) → review+
(In reply to Matteo Ferretti [:matteo][:zer0] from comment #1)
> Sorry for the long waiting; Looks good to me. Maybe we should point what is
> "officially" supported, but I think at this point is not really necessary.
Thabk you for the review! I think there's an MDN page somewhere touching on the subject of SDK extensions outside of Firefox. I'll look it up and extend it if it makes sense.
https://hg.mozilla.org/mozilla-central/rev/02cf3a4bf42a
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
You need to log in before you can comment on or make changes to this bug.