1248787 - test_gfxBlacklist_prefs.js fails consistently

Status: NEW

(Core :: Graphics, defect, P3)

Description

[Dave Townsend [:mossop]]

A bug in this test file meant that it was never actually running and so appeared to be passing all the time. I fixed that bug in bug 1245916 but now the test perma-fails. I don't know if the failure is expected or worth looking at so I'm just going to disable it and file this bug.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: MozReview Request: [mq]: 1248787

Review commit: https://reviewboard.mozilla.org/r/48559/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/48559/

Comment 2

[Benoit Girard (:BenWa)]

Pushed the try, let's see what's failing.

Comment 3

[Benoit Girard (:BenWa)]

Comment on attachment 8744475 [details]
MozReview Request: [mq]: 1248787

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/48559/diff/1-2/

Comment 4

[Benoit Girard (:BenWa)]

Failure is a timeout. Taking a look.

Comment 5

[Benoit Girard (:BenWa)]

It looks like we can't load the blocklist at all on mac. The test I looked at either early return on mac or check FEATURE_STATUS_OK. I couldn't find a single testing doing any useful negative check from the loaded blacklist.

http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/extensions/test/xpcshell/test_gfxBlacklist_Device.js#78

These test don't look very well designed since they will past with no loaded blacklist.

This is the network error that we get:
 0:04.26 PROCESS_OUTPUT: Thread-15 (pid:27993) "*** Blocklist::notify: Requesting http://localhost:55601/data/test_gfxBlacklist.xml"
 0:04.26 PROCESS_OUTPUT: Thread-15 (pid:27993) "[27993] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80520012: file /Users/bgirard/mozilla/mozilla-central/tree/extensions/cookie/nsPermissionManager.cpp, line 2606"