1248799 - [coverity] Potential null pointer dereference in ToolbarDisplayLayout

Status: RESOLVED DUPLICATE of bug 1236431

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

via Coverity:

*** CID 123355:  Null pointer dereferences  (FORWARD_NULL)
/mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarDisplayLayout.java: 363 in org.mozilla.gecko.toolbar.ToolbarDisplayLayout.updateProgress(org.mozilla.gecko.Tab)()
357         private void updateProgress(Tab tab) {
358             final boolean shouldShowThrobber = (tab != null &&
359                                                 tab.getState() == Tab.STATE_LOADING);
360
361             updateUiMode(shouldShowThrobber ? UIMode.PROGRESS : UIMode.DISPLAY);
362
>>>     CID 123355:  Null pointer dereferences  (FORWARD_NULL)
>>>     Calling a method on null object "tab".
363             if (Tab.STATE_SUCCESS == tab.getState() && mTrackingProtectionEnabled) {
364                 mActivity.showTrackingProtectionPromptIfApplicable();
365             }
366         }
367
368         private void updateUiMode(UIMode uiMode) {

Comment 1

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

Attachment: MozReview Request: Bug 1248799 - Don't call method on potentially null tab Object. r=sebastian

Review commit: https://reviewboard.mozilla.org/r/35189/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35189/

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

I already fixed this as part of the "pre" patch in bug 1236431. :)

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8720033 [details]
MozReview Request: Bug 1248799 - Don't call method on potentially null tab Object. r=sebastian

(In reply to Sebastian Kaspari (:sebastian) from comment #2)
> I already fixed this as part of the "pre" patch in bug 1236431. :)

http://hg.mozilla.org/integration/fx-team/rev/7945d91d718d

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Also see bug 1248908: This tool wants to remove the null checks again. And it seems like it's right.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only; no longer employed by Mozilla]]

(comment 2)