1248847 - Add DEBUG-only assert for AccessibleCaretEventHub refcount > 1

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

The precondition to make bug 1246918 works is that all the entry points to AccessibleCaretEventHub already add a reference to the Hub.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Mats suggests we add a DEBUG-only assert to make sure the refcount > 1 as in bug1246918 comment 29.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: MozReview Request: Bug 1248847 - Assert AccessibleCaretEventHub mRefCnt > 1 in all its entry points. r=mats

Review commit: https://reviewboard.mozilla.org/r/35433/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35433/

Comment 3

[Mats Palmgren (inactive)]

Comment on attachment 8720767 [details]
MozReview Request: Bug 1248847 - Assert AccessibleCaretEventHub mRefCnt > 1 in all its entry points. r=mats

https://reviewboard.mozilla.org/r/35433/#review32111

The assertions looks good, but I don't undesrtand why you're removing the 'explicit' on the ctors in the test.  Perhaps that part is just an accidental change?

r=mats

Comment 4

[Mats Palmgren (inactive)]

Comment on attachment 8720767 [details]
MozReview Request: Bug 1248847 - Assert AccessibleCaretEventHub mRefCnt > 1 in all its entry points. r=mats

https://reviewboard.mozilla.org/r/35433/#review32113

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

https://reviewboard.mozilla.org/r/35433/#review32111

Those ctors have no argument so nothing can be implicited coverted to them. Thefore the 'explicit' seems like a noise to me so I remove them while I'm here. But it does not harm to write 'explicit' though. I should have explain this in the commit message.

Comment 6

[Mats Palmgren (inactive)]

OK, my mistake.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a27cd3e26cc1

Comment 8

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c372f284cdd7

Comment 9

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8720767 [details]
MozReview Request: Bug 1248847 - Assert AccessibleCaretEventHub mRefCnt > 1 in all its entry points. r=mats

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35433/diff/1-2/

Comment 10

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Try result for patch set 2 in mozreview. All build tasks are green.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=996f97915b86

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9163c83ed1a8

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9163c83ed1a8