Closed Bug 1248847 Opened 4 years ago Closed 4 years ago

Add DEBUG-only assert for AccessibleCaretEventHub refcount > 1

Categories

(Core :: DOM: Selection, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The precondition to make bug 1246918 works is that all the entry points to AccessibleCaretEventHub already add a reference to the Hub.
Mats suggests we add a DEBUG-only assert to make sure the refcount > 1 as in bug1246918 comment 29.
Assignee: nobody → tlin
Depends on: 1246918
Attachment #8720767 - Flags: review?(mats)
Comment on attachment 8720767 [details]
MozReview Request: Bug 1248847 - Assert AccessibleCaretEventHub mRefCnt > 1 in all its entry points. r=mats

https://reviewboard.mozilla.org/r/35433/#review32111

The assertions looks good, but I don't undesrtand why you're removing the 'explicit' on the ctors in the test.  Perhaps that part is just an accidental change?

r=mats
Comment on attachment 8720767 [details]
MozReview Request: Bug 1248847 - Assert AccessibleCaretEventHub mRefCnt > 1 in all its entry points. r=mats

https://reviewboard.mozilla.org/r/35433/#review32113
Attachment #8720767 - Flags: review+
https://reviewboard.mozilla.org/r/35433/#review32111

Those ctors have no argument so nothing can be implicited coverted to them. Thefore the 'explicit' seems like a noise to me so I remove them while I'm here. But it does not harm to write 'explicit' though. I should have explain this in the commit message.
OK, my mistake.
Comment on attachment 8720767 [details]
MozReview Request: Bug 1248847 - Assert AccessibleCaretEventHub mRefCnt > 1 in all its entry points. r=mats

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35433/diff/1-2/
Attachment #8720767 - Attachment description: MozReview Request: Bug 1248847 - Assert AccessibleCaretEventHub mRefCnt > 1 in all its entry points → MozReview Request: Bug 1248847 - Assert AccessibleCaretEventHub mRefCnt > 1 in all its entry points. r=mats
Try result for patch set 2 in mozreview. All build tasks are green.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=996f97915b86
https://hg.mozilla.org/mozilla-central/rev/9163c83ed1a8
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.