1248863 - IonMonkey: MIPS: Fix MDefinition::constantValue re-factored

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[hev [:hev]]

Sync changes of Bug 1246658 to MIPS.

Comment 1

[hev [:hev]]

Attachment: 0003-IonMonkey-MIPS-Fix-MDefinition-constantValue-re-fact.patch

Comment 2

[Tooru Fujisawa [:arai]]

Comment on attachment 8720142 [details] [diff] [review]
0003-IonMonkey-MIPS-Fix-MDefinition-constantValue-re-fact.patch

Review of attachment 8720142 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/mips-shared/Lowering-mips-shared.cpp
@@ +305,2 @@
>          // A bounds check is only skipped for a positive index.
> +        MOZ_ASSERT(ptr->toConstant().toInt32() >= 0);

ptr->toConstant()->toInt32()

@@ +318,5 @@
>      MOZ_ASSERT(ptr->type() == MIRType_Int32);
>      LAllocation ptrAlloc;
>  
> +    if (ptr->isConstant() && !ins->needsBoundsCheck()) {
> +        MOZ_ASSERT(ptr->toConstant().toInt32() >= 0);

here too.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43e61da8cc43

Comment 4

[hev [:hev]]

Attachment: 0001-IonMonkey-MIPS32-Fix-LIRGeneratorMIPS-visitBox.patch

Comment 5

[Tooru Fujisawa [:arai]]

Comment on attachment 8720660 [details] [diff] [review]
0001-IonMonkey-MIPS32-Fix-LIRGeneratorMIPS-visitBox.patch

Review of attachment 8720660 [details] [diff] [review]:
-----------------------------------------------------------------

thank you :)

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2b8d19ce2cfa

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/43e61da8cc43

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2b8d19ce2cfa