1248883 - missing ${platform}_info.txt files

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[Rail Aliiev [:rail]]

https://dxr.mozilla.org/build-central/search?q=_info.txt&redirect=false&case=false and they may be used by other external consumers (socorro?).

Comment 1

[Rail Aliiev [:rail]]

This is how we generate those files:

https://dxr.mozilla.org/build-central/source/buildbotcustom/process/factory.py#2624-2653


We can probably move this logic to either makefiles or mozharness.

Comment 2

[Rail Aliiev [:rail]]

mshal, do you have any preferences on how to implement this?

Comment 3

[[e-mail] (:bhearsum)]

Can we confirm that they are actually used before we cargo cult this forward? Even if they are used, maybe there's a simpler thing for consumers to use?

Comment 4

[Chris AtLee [:catlee]]

AIUI, they are currently used by socorro to discover which buildids are valid release builds. Do we have a better way of providing this information?

Comment 5

[Rail Aliiev [:rail]]

Something tells me that using "ftp platforms" (mac, not macosx64) would be easier in makefiles. Then beetmover can rename them and copy to the candidates directory.

Comment 6

[Nick Thomas [:nthomas] (UTC+12)]

See also bug 1153352 for a Socorro API to submit to (not implemented). catlee, peterbe, and myself have had several conversations about this but not converged on a solution.

Comment 7

[Rail Aliiev [:rail]]

Q&D patch pushed to date: https://hg.mozilla.org/projects/date/rev/cf3953635ba2
Need to adjust the beetmover templates too

Comment 8

[Rail Aliiev [:rail]]

beetmover templates: https://hg.mozilla.org/projects/date/rev/950aa0ebd0c9

Comment 9

[Rail Aliiev [:rail]]

Attachment: info_make.diff

worked fine on date

Comment 10

[Rail Aliiev [:rail]]

Attachment: info_beets.diff

Comment 11

[Michael Shal [:mshal]]

Comment on attachment 8721079 [details] [diff] [review]
info_make.diff

LGTM. Are we eventually planning to use the existing json file rather than this separate txt file? If so, do we have a bug on file for that?

Comment 12

[Rail Aliiev [:rail]]

(In reply to Michael Shal [:mshal] from comment #11)
> Comment on attachment 8721079 [details] [diff] [review]
> info_make.diff
> 
> LGTM. Are we eventually planning to use the existing json file rather than
> this separate txt file? If so, do we have a bug on file for that?

I filed bug 1249753

Comment 13

[Rail Aliiev [:rail]]

Comment on attachment 8721079 [details] [diff] [review]
info_make.diff

https://hg.mozilla.org/integration/mozilla-inbound/rev/f1eb5abe525e

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/401bfec3e35a

Comment 15

[Rail Aliiev [:rail]]

Comment on attachment 8721081 [details] [diff] [review]
info_beets.diff

https://hg.mozilla.org/integration/mozilla-inbound/rev/401bfec3e35a

Comment 16

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f1eb5abe525e
https://hg.mozilla.org/mozilla-central/rev/401bfec3e35a

Comment 17

[Rail Aliiev [:rail]]

Comment on attachment 8721079 [details] [diff] [review]
info_make.diff

This patch is required by release promotion. I'd like to uplift this to aurora to let it be in beta automatically. It's been on m-c for a week so far and looks sane. The risk is very low, because it adds a new file, without changing existing ones.

Comment 18

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8721079 [details] [diff] [review]
info_make.diff

Sounds good to me, I'm excited for release promotion.

Comment 19

[Liz Henry (:lizzard) (relman/hg->git project)]

Rail, both patches here?

Comment 20

[Rail Aliiev [:rail]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #19)
> Rail, both patches here?

I'll land the second with NPOTB a=release :) because it doesn't affect anything except release promotion

Comment 21

[Rail Aliiev [:rail]]

Comment on attachment 8721079 [details] [diff] [review]
info_make.diff

The same thing for ESR 45, so we are ready for release promotion

Comment 22

[Rail Aliiev [:rail]]

Comment on attachment 8721079 [details] [diff] [review]
info_make.diff

This was landed when I grafted patches a while ago apparently.