Closed Bug 1248890 Opened 4 years ago Closed 4 years ago

enable rust for win64 beta and release builds

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox47 affected, firefox48 fixed)

RESOLVED FIXED
mozilla48
Tracking Status
firefox47 --- affected
firefox48 --- fixed

People

(Reporter: rillian, Assigned: rillian)

References

Details

Attachments

(1 file)

Per bug 1243363, rust is now riding the trains (official builds) to release on linux and mac. Win64 should do the same.

(a) We don't have all the support we want for integration, but neither do we have much code in rust yet. Developing integration and implementation in parallel lets us move faster.

(b) We're committed to this experiment, so the earlier we get testing data the better. In particular, beta and release use is very different from nightly and dev edition. Better to find issues before we depend on the rust implementation of anything.

(c) Release drivers discovered we don't have proper testing of the mozconfig whitelist settings. Let's make their lives easier.
Which gecko trees should this land in, Just central (47) or also aurora (46)?

I had a brief chat with lizzard yesterday about rust and wanted to make sure we're all on the same page here.

It also landed for win32 builds on 47 in https://bugzilla.mozilla.org/show_bug.cgi?id=1248461 in a way that will ride to beta/release at the least ;-)
Flags: needinfo?(giles)
It's fine for this to ride the trains. But I guess we need a code change either way, so doing Aurora as well remains my preference. If I understand bug 1178897 correctly, the rust code won't hook gecko's allocator on windows the way it will on linux and mac, but that's not an issue for the rust code we have in tree for 46 or 47, so I'd rather have the pilot testing.
Flags: needinfo?(giles)
We've let this ride the trains for other archs. Should do so
for win64 as well.

Review commit: https://reviewboard.mozilla.org/r/46889/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/46889/
Attachment #8741991 - Flags: review?(rail)
Comment on attachment 8741991 [details]
MozReview Request: Bug 1248890 - Enable rust for win64 beta and release builds. r?rail

https://reviewboard.mozilla.org/r/46889/#review43485

Yay Rust!
Attachment #8741991 - Flags: review?(rail) → review+
Assignee: nobody → giles
https://reviewboard.mozilla.org/r/46889/#review43933

::: browser/config/mozconfigs/win64/release:24
(Diff revision 1)
>  # safeguard against someone forgetting to re-set EARLY_BETA_OR_EARLIER in
>  # defines.sh during the beta cycle
>  export BUILDING_RELEASE=1
>  
> +'. "$topsrcdir/build/mozconfig.rust"',
> +

Extra quote and comma here, rejected by compare-mozconfigs-wrapper.py
https://hg.mozilla.org/mozilla-central/rev/0737f2eaee1d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.