124903 - Tables with cells and specified width causing incorrect table layout: text wrap (amazon.com)

Status: RESOLVED FIXED

(Core :: Layout: Tables, defect, P3)

Description

[/\/\arcio Galli]

Tested with:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.8+) Gecko/20020211

I will file the testcase.

Comment 1

[/\/\arcio Galli]

Attachment: Two tables Testcase. The first case is the incorrect, the second is the correct expected behavior - this was created from real case: amazon.com product item pages.

Note in the first testcase that the second TD element have width="1". 

In the second testcase, I removed the width="1" from the table cells. Note that
the contents of the 3rd cell is not wrapping in the second testcase.

Comment 2

[/\/\arcio Galli]

Real case example:
http://www.amazon.com/exec/obidos/ASIN/0439286115/qid=1013464426/sr=5-2/ref=cm_lm_asin/104-0792733-2179912
Note that there is an extra white space on top of the table with two images of
the book covers. That happens because the text in the right side is wrapped. 

Comment 3

[/\/\arcio Galli]

This also happens with Win98.

Comment 4

[Boris Zbarsky [:bzbarsky]]

HTML tables.

Comment 5

[/\/\arcio Galli]

Attachment: Testcase 2. When contents of 1st column are bigger than its specified width, 2nd column is affected (wraps content).

This testcase is much better. It's basically the following figure. 

+---------------+----------+-----------+
| width=100	| no width | width=50% |
| ............. | .........| ......... |
| img(width>100)| wraps    |	       |
|		| content  |	       |
+---------------+----------+-----------+
When the content of the 1st column is bigger than the TD specified width, it
affects the second column causing contents to wrap. This also happens with text
content in the first column. You can add a text content like the word 'M'. If
you gradually decrease the width of the TD (1st column), at some point the 2nd
column will wrap. This some point matches with the width size of the word 'M'.

Comment 6

[Jerry]

Works for me with 20020818 build.
Reporter, can you test it with the latest build?

Comment 7

[karnaze (gone)]

mass reassign to default owner

Comment 8

[Mike Cowperthwaite]

This bug is still open.  Marcio Galli, could you please verify that the problem
no longer exists for you?  It was reported as working OK back in August, and it
still seems to work for me with 1.4a.

Comment 9

[Boris Zbarsky [:bzbarsky]]

I'm seeing the problem with today's build... It looks like the columns for the
first table get widths based on declared or intrinsic sizes, then the second
column has to get wider and instead of rebalancing the whole table we just make
the third column narrower, since it has give....

It would make more sense to adjust the total table width, I'd think.

Comment 10

[j.j.]

Testcases wfm.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a3pre) Gecko/20070221 Minefield/3.0a3pre

Comment 11

[Boris Zbarsky [:bzbarsky]]

Fixed by reflow branch, looks like.  We should add reftests...

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Attachment: Reftests

Go ahead and check them in if you're happy with them (note that reftest.list in the patch assumes that the reftests in bug 105030 have already been checked in ;-)...)

Comment 13

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 257299 [details] [diff] [review]
Reftests

There's no 124903-1-ref.html in this diff.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Attachment: Reftests take 2

Whoops, sorry about that.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Attachment: I quit

Stupid stupid stupid...

Comment 16

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 257303 [details] [diff] [review]
I quit

Put that image in a separate file so it's obvious that they're including the same thing, and r=bzbarsky.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Attachment: Same patch as before, using solidblue.png

Carrying over r+ from before

Comment 18

[Boris Zbarsky [:bzbarsky]]

Checked in the test.