1249068 - Don't show suggested site tiles for sites that are already in Top Sites

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: screenshot

Was surprised to find these new defaults mingled in with my history on build update (master) on Top Sites. Since I can't delete these new defaults, we should not further cause annoyance by generating new tiles for these new defaults.

See screenshot.

Comment 1

[Aaron Train [:aaronmt]]

I anticipate, "Why can I delete the Amazon with the 'A' tile, but not the 'Amazon.com' tile".

Comment 2

[Bryan Munar (:bkmunar)]

Attachment: PR

r=bnicholson
r=sleroux

open to suggestions on for a better fix, but this works.

Comment 3

[Bryan Munar (:bkmunar)]

for whoever gets to it first*

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 8728135 [details] [review]
PR

This PR could use some simplification, and I have a feeling there's an easier way to do what you're trying to do. Let's go over this more tomorrow.

Comment 5

[Stephan Leroux [:sleroux]]

Comment on attachment 8728135 [details] [review]
PR

Deferring to Brian. Feel free to re-add me if you want another pair of eyes.

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8728135 [details] [review]
PR

Much better!

Comment 7

[Bryan Munar (:bkmunar)]

https://github.com/mozilla/firefox-ios/commit/2aef02e50d460ef0ec63573c0de5bad966bcf864

Comment 8

[Stephan Leroux [:sleroux]]

v3.x 242e7d1]