1249074 - When sideloaded add-ons are present when creating a new profile the user will be offered them on startup

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

When creating a profile and there are already sideloaded add-ons on the system we used to just disable the add-ons and the user would have to know to look for them in the add-ons manager. Since bug 1237820 that has been broken and instead now the user will be presented with the sideloading opt-in tab for every detected add-on.

Comment 1

[Dave Townsend [:mossop]]

Attachment: MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

Review commit: https://reviewboard.mozilla.org/r/35307/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35307/

Comment 2

[Robert Helmer [:rhelmer]]

Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

https://reviewboard.mozilla.org/r/35307/#review32159

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/85a6a1673026

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/85a6a1673026

Comment 5

[Dave Townsend [:mossop]]

Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

Approval Request Comment
[Feature/regressing bug #]: Bug 1237820
[User impact if declined]: When starting a new profile (fresh install) users may be presented with a number of tabs asking them to enable whatever add-ons are already installed on their system
[Describe test coverage new/current, TreeHerder]: Automated tests on m-c now
[Risks and why]: It's a trivial patch so low risk. The automated tests pass, though having manual QA done would be good as we won't see much feedback from beta/aurora/nightly users on this.
[String/UUID change made/needed]: None

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

Has tests, small change, we will probably need this soon, taking it.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/85b2e3b672e5

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Tracked for Fx45, 46 and 47 as this impacts a lot of add-ons (AFAIU).

Comment 9

[Vasilica Tamas, QA [:vtamas]]

I was able to reproduce this issue on Firefox 47.0a1 (2016-02-19) under Windows 10 64-bit.

Verified fixed on Firefox 47.0a1 (2016-02-24/25) and Firefox 45 beta 9 (20160223142613) under Windows 10 64-bit, Ubuntu 12.04 32-bit and Mac OS X 10.10.4. The sideloaded UI that allows the user to enable the add-on is not displayed on startup and the add-on is automatically disabled in Add-ons Manager.

Firefox 46.0a2 is still affected across all platforms and I do not understand why, since it is also tracked for 46.

Dave, any thoughts?

Comment 10

[Carsten Book [:Tomcat]]

has problems uplifting to release:

grafting 329949:85b2e3b672e5 "Bug 1249074 - Don't offer existing sideloaded add-ons to users when creating a new profile. r=rhelmer, a=sylvestre"
merging toolkit/mozapps/extensions/internal/XPIProviderUtils.js
merging toolkit/mozapps/extensions/test/xpcshell/xpcshell-shared.ini
warning: conflicts while merging toolkit/mozapps/extensions/internal/XPIProviderUtils.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging toolkit/mozapps/extensions/test/xpcshell/xpcshell-shared.ini! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue

Comment 11

[Dave Townsend [:mossop]]

Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

I actually intended to request aurora approval for this, not release approval. If oyu still want it on release I can figure out the merge failures.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

Yes, let's uplift this to aurora, we want users to see their sideloaded addons.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Thanks for catching this Vasilica!!

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/be8753802e71

Comment 15

[Vasilica Tamas, QA [:vtamas]]

Confirm that this issue is fixed on Firefox 46.0a2 (2016-02-29) under Windows 10 64-bit, Ubuntu 12.04 32-bit and Mac OS X 10.11.