When sideloaded add-ons are present when creating a new profile the user will be offered them on startup

VERIFIED FIXED in Firefox 45

Status

()

Toolkit
Add-ons Manager
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
mozilla47
Points:
---

Firefox Tracking Flags

(firefox45+ verified, firefox46+ verified, firefox47+ verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
When creating a profile and there are already sideloaded add-ons on the system we used to just disable the add-ons and the user would have to know to look for them in the add-ons manager. Since bug 1237820 that has been broken and instead now the user will be presented with the sideloading opt-in tab for every detected add-on.
(Assignee)

Comment 1

2 years ago
Created attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

Review commit: https://reviewboard.mozilla.org/r/35307/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35307/
Attachment #8720421 - Flags: review?(rhelmer)
Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

https://reviewboard.mozilla.org/r/35307/#review32159
Attachment #8720421 - Flags: review?(rhelmer) → review+

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/85a6a1673026

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/85a6a1673026
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
(Assignee)

Comment 5

2 years ago
Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

Approval Request Comment
[Feature/regressing bug #]: Bug 1237820
[User impact if declined]: When starting a new profile (fresh install) users may be presented with a number of tabs asking them to enable whatever add-ons are already installed on their system
[Describe test coverage new/current, TreeHerder]: Automated tests on m-c now
[Risks and why]: It's a trivial patch so low risk. The automated tests pass, though having manual QA done would be good as we won't see much feedback from beta/aurora/nightly users on this.
[String/UUID change made/needed]: None
Attachment #8720421 - Flags: approval-mozilla-release?
Attachment #8720421 - Flags: approval-mozilla-beta?
Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

Has tests, small change, we will probably need this soon, taking it.
Attachment #8720421 - Flags: approval-mozilla-release?
Attachment #8720421 - Flags: approval-mozilla-release+
Attachment #8720421 - Flags: approval-mozilla-beta?
Attachment #8720421 - Flags: approval-mozilla-beta+

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/85b2e3b672e5
status-firefox45: affected → fixed

Comment 8

2 years ago
Tracked for Fx45, 46 and 47 as this impacts a lot of add-ons (AFAIU).
tracking-firefox45: ? → +
tracking-firefox46: ? → +
tracking-firefox47: ? → +
Flags: qe-verify+
I was able to reproduce this issue on Firefox 47.0a1 (2016-02-19) under Windows 10 64-bit.

Verified fixed on Firefox 47.0a1 (2016-02-24/25) and Firefox 45 beta 9 (20160223142613) under Windows 10 64-bit, Ubuntu 12.04 32-bit and Mac OS X 10.10.4. The sideloaded UI that allows the user to enable the add-on is not displayed on startup and the add-on is automatically disabled in Add-ons Manager.

Firefox 46.0a2 is still affected across all platforms and I do not understand why, since it is also tracked for 46.

Dave, any thoughts?
Status: RESOLVED → VERIFIED
status-firefox45: fixed → verified
status-firefox47: fixed → verified
Flags: needinfo?(dtownsend)
has problems uplifting to release:

grafting 329949:85b2e3b672e5 "Bug 1249074 - Don't offer existing sideloaded add-ons to users when creating a new profile. r=rhelmer, a=sylvestre"
merging toolkit/mozapps/extensions/internal/XPIProviderUtils.js
merging toolkit/mozapps/extensions/test/xpcshell/xpcshell-shared.ini
warning: conflicts while merging toolkit/mozapps/extensions/internal/XPIProviderUtils.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging toolkit/mozapps/extensions/test/xpcshell/xpcshell-shared.ini! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(Assignee)

Comment 11

2 years ago
Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

I actually intended to request aurora approval for this, not release approval. If oyu still want it on release I can figure out the merge failures.
Flags: needinfo?(dtownsend)
Attachment #8720421 - Flags: approval-mozilla-aurora?
Comment on attachment 8720421 [details]
MozReview Request: Bug 1249074: Don't offer existing sideloaded add-ons to users when creating a new profile. r?rhelmer

Yes, let's uplift this to aurora, we want users to see their sideloaded addons.
Attachment #8720421 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Thanks for catching this Vasilica!!

Comment 14

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/be8753802e71
status-firefox46: affected → fixed
Confirm that this issue is fixed on Firefox 46.0a2 (2016-02-29) under Windows 10 64-bit, Ubuntu 12.04 32-bit and Mac OS X 10.11.
status-firefox46: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.