1249161 - Account preferences UI is askew in SIPE settings

Status: RESOLVED WONTFIX

(Chat Core :: General, defect)

Description

[bgmCoder]

Attachment: screenshot_Instantbird [instantbird]_001.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20151216175450

Steps to reproduce:

Create an account for Office Communicator.
Then go to Accounts Manager.
Open properties for that account
Go to the Advanced Options tab.



Actual results:

The edit boxes are all out of whack.


Expected results:

Uh, the edit boxes should be in whack.

(note - there is also an edit box of the same nature in the account wizard for Office Communicator)

Comment 1

[Patrick Cloke [:clokep]]

Do you see any errors in the error console when opening the account preferences? (See Tools > Error console)

Comment 2

[bgmCoder]

No, there are no errors in the console.

Comment 3

[bgmCoder]

Attachment: Teeny Little Edit Boxes

The first image I uploaded is wrong.  But this one is correct.

Comment 4

[bgmCoder]

The edit boxes are in the Account Settings for Office Communicator are only about 5 to 10 pixels wide.  You can't see what is in them.  However, you CAN paste into those boxes.  So the boxes do *work* - you just can't see the contents because they are too small.

Comment 5

[Patrick Cloke [:clokep]]

This is because the descriptions are insanely long for this protocol. I suspect the 'easy' fix is to put the labels and inputs on separate lines.

Comment 6

[Patrick Cloke [:clokep]]

Attachment: Separate line per option

Comment 7

[Patrick Cloke [:clokep]]

Attachment: Patch v1

This moves text inputs to a separate line. Note that this looks a little funky for things like IRC Port where there's a super short label AND it's a number input.

Comment 8

[Patrick Cloke [:clokep]]

Attachment: Patch v1.1

Oops, I had an unrelated whitespace change.

Comment 9

[aleth [:aleth]]

There also seems to be an issue when creating a new SIPE account on the first page - it also doesn't fit.

What about a maxwidth of 50% or 75% or whatever on the column instead?

Is there a good reason why the account properties modal dialog is narrower than the already quite small account manager window? It looks a bit cramped.

Comment 10

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #9)
> Is there a good reason why the account properties modal dialog is narrower
> than the already quite small account manager window? It looks a bit cramped.

e.g. how does 100% here look? https://dxr.mozilla.org/comm-central/source/im/content/account.xul#14

Comment 11

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #10)
> e.g. how does 100% here look?
> https://dxr.mozilla.org/comm-central/source/im/content/account.xul#14

(I ask because the same options seem to display OK for me in the new account wizard.)

Comment 12

[Patrick Cloke [:clokep]]

(In reply to aleth [:aleth] from comment #11)
> (In reply to aleth [:aleth] from comment #10)
> > e.g. how does 100% here look?
> > https://dxr.mozilla.org/comm-central/source/im/content/account.xul#14
> 
> (I ask because the same options seem to display OK for me in the new account
> wizard.)

This didn't seem to change anything for me. Even so, I think this is just a band-aid over the problem. We don't "control" the strings of the labels and how long they are, so assuming people will have a long enough textbox to type what they need isn't very accurate.

Comment 13

[aleth [:aleth]]

Attachment: Account properties, OSX

Comment 14

[aleth [:aleth]]

Attachment: SIPE username entry step

The new account wizard shows the same options. Note here there is no problem. Maybe the CSS should be compared? Of course the window is wider - I already suggested fixing that.

Comment 15

[aleth [:aleth]]

Attachment: Account properties in the wizard

Note on this screenshot that the code in the account wizard seems to have no trouble word-wrapping long labels so nothing breaks.

Comment 16

[aleth [:aleth]]

Attachment: Account properties in the wizard showing wordwrap

Non-fatal brokenness mentioned in comment 9.

Comment 17

[aleth [:aleth]]

To be clear: I would be OK with putting the label on a separate line, as in your patch, if you prefer that style. However you should then adjust the CSS so that the spacing works, ie. that it is clear which label belongs to which textbox.

Independently of this, I still think the account properties modal dialog should have the same width as the account wizard modal dialog, as it makes things much more legible and textboxes are less cramped.

My comment regarding wordwrap was about attachment 8731290 [details], where it fails. (There is clearly wordwrap on attachment 8731289 [details] - it's just that there's not enough room left for the textboxes.)

Comment 18

[Wayne Mery (:wsmwk)]

Patrick you will want to spin the next review to someone else.

Comment 19

[Patrick Cloke [:clokep]]

Comment on attachment 8731005 [details] [diff] [review]
Patch v1.1

Thanks. Maybe nhnt11 has an idea about this.

Comment 20

[Patrick Cloke [:clokep]]

This might be an issue for other protocols, but SIPE is no longer a thing (since purplexpcom no longer works).