1249170 - Change "options" to "edit" in Bookmarked snackbar

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Current:

+--------------------------------+
|                                |
| Bookmark added         OPTIONS |
|                                |
+--------------------------------+

Proposed: 

+--------------------------------+
|                                |
| Bookmarked                EDIT |
|                                |
+--------------------------------+

This makes a lot more sense with the folder management stuff we're doing. I think its more valuable than "Add to homescreen" which is the only other option in the dialog that pops up after a user hits "option". 

We can think about other ways to promote "Add to home screen" too but I don't think this snackbar is the best place to do that. Here, it's kinda getting in the way of our other features (like Edit). 

Perhaps inside the Edit dialog once that's done but we also have other ways to "Add to home screen" anyway.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Matej, 

quick question, do you have any strong disagreements for using "Bookmarked" as opposed to "Bookmark added"? its more concise and contrasts nicely when we have a "Bookmark removed" message.

Comment 2

[Matej Novak [:matej]]

(In reply to Anthony Lam (:antlam) from comment #1)
> Matej, 
> 
> quick question, do you have any strong disagreements for using "Bookmarked"
> as opposed to "Bookmark added"? its more concise and contrasts nicely when
> we have a "Bookmark removed" message.

My only reservation is that it creates another form of the word (though I guess we're using it as a verb elsewhere, too). 

I also think it's better to keep the parallel construction: if we have "removed," why not keep "added"?

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Matej Novak [:matej] from comment #2)
> My only reservation is that it creates another form of the word (though I
> guess we're using it as a verb elsewhere, too). 

Yeah, that's my thinking too. Some other places just don't have that screen space to have two words either.

> I also think it's better to keep the parallel construction: if we have
> "removed," why not keep "added"?

Actually, since these snackbars are quite temporary in nature, and they never appear next to each other, the difference makes for better glance-ability I find.

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.