1249260 - When I start Firefox 44.02 for android, it frequently advises me to update to the latest version,even though it's up to date.

Status: RESOLVED INCOMPLETE

(Snippets :: Campaign, task)

Description

[ken_speakman]

User Agent: Mozilla/5.0 (Android 5.1.1; Tablet; rv:44.0) Gecko/44.0 Firefox/44.0
Build ID: 20160210083852
Firefox for Android

Steps to reproduce:

It happens frequently since the update to this version. It shows the message at the bottom of the screen and when I tap to upgrade, I find I am already up to date. Both android and all the apps are always up to date.


Actual results:

It failed to update.


Expected results:

Nothing - it was already at the latest version.

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

Someone must have misconfigured the snippet server.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

Via email this has been disabled.

Comment 3

[Giorgos Logiotatidis [:giorgos]]

I believe the discussion is about Snippets with ID 182 and 183. (Jess please confirm).

These snippets atm use a Client Match Rule (aka CMR) to limit delivery to clients matching version 34 with the following regex (^34\.0.*$)

I re-enabled snippet 182 temporarily in an effort to reproduce the error. I requested snippets with the following URL, acting like a Version 44.0.2 Fennec

$ curl https://snippets.mozilla.com/json/1/Fennec/44.0.2/20160209150441/Android_arm-eabi-gcc3/en-US/release/Linux%2021/default/default/
[]

And I got an empty response "[]" as I would expect b/c there are no active snippets matching this configuration.

I tried again as Fennec 34.0.1

$ curl https://snippets.mozilla.com/json/1/Fennec/34.0.1/20141218164527/Android_arm-eabi-gcc3/en-US/release/Linux%2010/default/default/

[{"url": "http://mzl.la/217sXZn", "text": "Attention: Update Firefox for the newest features and best security. Install it now.", "id": 182, "weight": 100, "icon": "data:image/png;base64,i....}]


and I got the snippet.

I also forced my up-to-date Fennec to update snippets by reseting the snippet-update-timer and I got no new snippets.

So technically the filtering seems to work as expected. 

Jess can you please verify that the CMR to limit to Version 34 was in place from the very first moment you enabled those Snippets?

Comment 4

[Jessica]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #3)
> I believe the discussion is about Snippets with ID 182 and 183. (Jess please
> confirm).
> 
> These snippets atm use a Client Match Rule (aka CMR) to limit delivery to
> clients matching version 34 with the following regex (^34\.0.*$)
> 
> I re-enabled snippet 182 temporarily in an effort to reproduce the error. I
> requested snippets with the following URL, acting like a Version 44.0.2
> Fennec
> 
> $ curl
> https://snippets.mozilla.com/json/1/Fennec/44.0.2/20160209150441/Android_arm-
> eabi-gcc3/en-US/release/Linux%2021/default/default/
> []
> 
> And I got an empty response "[]" as I would expect b/c there are no active
> snippets matching this configuration.
> 
> I tried again as Fennec 34.0.1
> 
> $ curl
> https://snippets.mozilla.com/json/1/Fennec/34.0.1/20141218164527/Android_arm-
> eabi-gcc3/en-US/release/Linux%2010/default/default/
> 
> [{"url": "http://mzl.la/217sXZn", "text": "Attention: Update Firefox for the
> newest features and best security. Install it now.", "id": 182, "weight":
> 100, "icon": "data:image/png;base64,i....}]
> 
> 
> and I got the snippet.
> 
> I also forced my up-to-date Fennec to update snippets by reseting the
> snippet-update-timer and I got no new snippets.
> 
> So technically the filtering seems to work as expected. 
> 
> Jess can you please verify that the CMR to limit to Version 34 was in place
> from the very first moment you enabled those Snippets?

Hi Giorgos,

Yes, I applied the filter before enabling it.  Margaret tested on her device as soon as I enabled it to be sure it was working as well. 

It seems that it was working when I first deployed as it was live for an entire day with no feedback.  Were there any system updates during the past two days that potentially affected this? 

Also, I see it was referenced above that a tablet was used when producing that error originally.  Does that factor into it at all?  Tablet vs. Mobile device?

Just brainstorming possibilities!

Thanks for your help.

Comment 5

[Giorgos Logiotatidis [:giorgos]]

OK thanks for verifying Jess.

Margaret what happens with the snippets cache in the following scenario:
 - User on Fx 34 sees the snippet
 - User upgrades to Fx 44

If the snippet cache is not flushed then user will get the upgrade snippet again, on the new version.

Could this be possible?

Comment 6

[Giorgos Logiotatidis [:giorgos]]

(In reply to Jessica from comment #4)
> It seems that it was working when I first deployed as it was live for an
> entire day with no feedback.  Were there any system updates during the past
> two days that potentially affected this? 
I pushed a minor change that only changes the order CMRs appear in the UI. This is not related and I cannot reproduce the problem today with the new change in place. So short answer is "No, no changes"
 
> Also, I see it was referenced above that a tablet was used when producing
> that error originally.  Does that factor into it at all?  Tablet vs. Mobile
> device?

That shouldn't make any difference.

Comment 7

[:Margaret Leibovic]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #5)
> OK thanks for verifying Jess.
> 
> Margaret what happens with the snippets cache in the following scenario:
>  - User on Fx 34 sees the snippet
>  - User upgrades to Fx 44
> 
> If the snippet cache is not flushed then user will get the upgrade snippet
> again, on the new version.
> 
> Could this be possible?

Good thinking! I suspect this is exactly what's happening.

Unfortunately, my patch for bug 1227743 would prevent this issue, but I haven't landed that yet (planning to do that today). Although that code wouldn't be in 34, so that still wouldn't make a difference.

I'm not sure of any good way to address this without changes to the client, which won't make it into 44 :/

My fix for bug 1227743 is pretty simple, I'll land that and request uplift to beta, and maybe we'll just need to wait to try this campaign again until after 45 ships in a few weeks.

Comment 8

[Giorgos Logiotatidis [:giorgos]]

Aha! Thanks for fixing this Margaret. I'll file a bug to make sure that snippet cache gets flushed on upgrades on Desktop too.

Comment 9

[Giorgos Logiotatidis [:giorgos]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #8)
> Aha! Thanks for fixing this Margaret. I'll file a bug to make sure that
> snippet cache gets flushed on upgrades on Desktop too.

For the record bug 1249611

Comment 10

[Kevin Brosnan [Ex-Mozilla]]

(In reply to Giorgos Logiotatidis [:giorgos] from comment #5)
> OK thanks for verifying Jess.
> 
> Margaret what happens with the snippets cache in the following scenario:
>  - User on Fx 34 sees the snippet
>  - User upgrades to Fx 44
> 
> If the snippet cache is not flushed then user will get the upgrade snippet
> again, on the new version.
> 
> Could this be possible?

That was not the case when I saw the snippet. I was using my primary phone which has been on Firefox 44 for weeks.

Comment 11

[Giorgos Logiotatidis [:giorgos]]

(In reply to Kevin Brosnan [:kbrosnan] from comment #10)
> (In reply to Giorgos Logiotatidis [:giorgos] from comment #5)
> > OK thanks for verifying Jess.
> > 
> > Margaret what happens with the snippets cache in the following scenario:
> >  - User on Fx 34 sees the snippet
> >  - User upgrades to Fx 44
> > 
> > If the snippet cache is not flushed then user will get the upgrade snippet
> > again, on the new version.
> > 
> > Could this be possible?
> 
> That was not the case when I saw the snippet. I was using my primary phone
> which has been on Firefox 44 for weeks.

Thanks for clarifying Kevin. I found a bug fixed in the new codebase which was present in the legacy -but currently running- codebase too. I fixed in it bug 1250097 and pushed to production.

Since this bug was generating an incorrect set of client match rules in the case of JSON (Fennec) Snippets it must be related to this behavior. It's unclear to me why my manual testing with curl did not replicate the issue and I do not have a copy of the snippets db locally to investigate further.

From my end there's nothing else to do atm. I suggest that we enable the snippet and see obverse if this appears again in clients other than version 34.

Comment 12

[Giorgos Logiotatidis [:giorgos]]

Closing due to inactivity. Please re-open new bugs if still valid.