1249354 - Default sans-serif font being used changed to something less nice

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Logcat

I have a bugmail dashboard (you can find a static snapshot in the URL field) that uses font-family:sans-serif as the font on the body. As of yesterday (Feb 17 nightly) the font being used on my device changed from something nice-looking to something less nice-looking. IRC conversation sounds like it is possibly related to a failure in Downloaded Fonts which landed recently.

Attached is the logcat from Fennec startup up to and including loading the page in the URL field.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

> 02-18 18:54:59.135 20612 20639 D GeckoDLCCatalog: Loading from disk
> 02-18 18:54:59.136 20612 20639 D GeckoDLCCatalog: Catalog file does not exist: Bootstrapping initial catalog
> 02-18 18:54:59.136 20612 20639 D GeckoDLCCatalog: Loaded 0 elements
> 02-18 18:54:59.136 20612 20638 V DLCStudyAction: Done

We want to bootstrap the catalog but after that we still have 0 elements. This should only happen if MOZ_ANDROID_EXCLUDE_FONTS is false but then we'd ship fonts in the APK..

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

The fallback font should be Roboto on recent Android versions and Droid Sans on older versions. If those aren't being used, we should figure out why.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Screenshot

This is what it looks like on Nightly (zoomed in). Not sure which font it's using.

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1249354 - configure.in: Remove --disable-android-include-fonts configuration option. r=nalexander

This resembles what we are doing with MOZ_EXCLUDE_HYPHENATION_DICTIONARIES: We just have
a flag without any --disable-* configuration option.

Review commit: https://reviewboard.mozilla.org/r/35613/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35613/

Comment 5

[Ben Bucksch (:BenB)]

> Not sure which font it's using.

This looks like DejaVu Sans to me. And I like it.

Comment 6

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8721236 [details]
MozReview Request: Bug 1249354 - configure.in: Remove --disable-android-include-fonts configuration option. r=nalexander

https://reviewboard.mozilla.org/r/35613/#review32549

Ship it!

::: configure.in:3694
(Diff revision 1)
> +MOZ_ANDROID_EXCLUDE_FONTS=

I think we do not want this one line.  Empty is the default, and it is possible that this will overwrite a setting set in ``mobile/android/confvars.sh``.  As it happens, ``confvars.sh`` (and any branding shell script) is evaluated later, so it's okay; but let's drop it.  (In fact, we should drop all of this cruft, but one thing at a time.)

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8721236 [details]
MozReview Request: Bug 1249354 - configure.in: Remove --disable-android-include-fonts configuration option. r=nalexander

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35613/diff/1-2/

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8cc2ebfd125a

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8cc2ebfd125a