Closed Bug 1249432 Opened 4 years ago Closed 4 years ago

fewer h2 parallel conns

Categories

(Core :: Networking: HTTP, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: mcmanus, Assigned: mcmanus)

References

Details

(Whiteboard: [necko-active][spdy])

Attachments

(2 files, 1 obsolete file)

force more transactions onto the same h2 session when we have opened
more than 1 (in parallel before we know they are h2). Not doing this
can impact h2 push negatively (the push cache misses, but everything
works ok). Its possible this is related to bug 1236650
Attached patch less h2 parallel conns (obsolete) — Splinter Review
Attachment #8721025 - Flags: review?(hurley)
Attachment #8721025 - Flags: review?(hurley) → review+
Attachment #8721348 - Flags: review?(hurley)
Attachment #8721025 - Attachment is obsolete: true
Attached patch INTERDIFFSplinter Review
this is the interdiff fyi.. it allows push on a stream marked goaway if we aren't using the session cache to store it in.
Comment on attachment 8721348 [details] [diff] [review]
less h2 parallel conns

Review of attachment 8721348 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM... I always forget about push listeners :/
Attachment #8721348 - Flags: review?(hurley) → review+
https://hg.mozilla.org/mozilla-central/rev/19d0559bb450
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.