1249434 - Add a "Show web fonts" advanced option

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[François Marier [:francois]]

Web fonts can be quite large and aren't all that necessary. It would be nice to give bandwidth-starved users a way to disable them just like they can disable images.

This is already built into gecko:

  browser.display.use_document_fonts (0 = fonts disabled, 1 = fonts enabled)

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Awesome. Barbara: Do we want to add this to AHA?

Comment 2

[Barbara Bermes [:barbara] - NI please!]

neat. good idea.

https://mozilla.aha.io/features/FENN-446

If we continue to add more bandwidth/data saving related features in our product, we should consider having an extra "data savings" section under settings.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I think this should go under Advanced, probably right below "Show images".

Show web fonts
Always | Only over Wi-Fi | Blocked

Comment 4

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #3)
> I think this should go under Advanced, probably right below "Show images".
> 
> Show web fonts
> Always | Only over Wi-Fi | Blocked

The pref Francois linked to isn't tied to wi-fi, so we'll have to manage this state ourselves. It looks like we could observe "network:link-type-changed" to keep track of when this changes.

Comment 5

[:Margaret Leibovic]

(In reply to :Margaret Leibovic from comment #4)
> (In reply to Anthony Lam (:antlam) from comment #3)
> > I think this should go under Advanced, probably right below "Show images".
> > 
> > Show web fonts
> > Always | Only over Wi-Fi | Blocked
> 
> The pref Francois linked to isn't tied to wi-fi, so we'll have to manage
> this state ourselves. It looks like we could observe
> "network:link-type-changed" to keep track of when this changes.

Although I don't see this actually used anywhere in the tree... does this actually work?

If not, is there any other way to observe a change of network type?

Comment 6

[:Margaret Leibovic]

For now, I decided to just expose a checkbox pref to turn web fonts on/off. We can file a follow-up if we find a way to enable/disable this setting when the network type changes.

Comment 7

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1249434 - Add a "Show web fonts" pref in advanced settings. r=jchen

Review commit: https://reviewboard.mozilla.org/r/35939/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35939/

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8722261 [details]
MozReview Request: Bug 1249434 - Add a "Show web fonts" pref in advanced settings. r=jchen

https://reviewboard.mozilla.org/r/35939/#review32607

LGTM

::: mobile/android/base/java/org/mozilla/gecko/PrefsHelper.java:224
(Diff revision 1)
> +        if (INT_TO_BOOL_PREFS.contains(pref)) {

else if

Comment 9

[Patrick McManus [:mcmanus]]

:bagder is the expert here.. but I think you may need to observe NS_NETWORK_LINK_TOPIC and then poll link type from that observation..

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/307f90b2422f1d2dcd4c43dbec00e3daf31a6306
Bug 1249434 - Add a "Show web fonts" pref in advanced settings. r=jchen

Comment 11

[Lina Butler [:lina]]

https://hg.mozilla.org/mozilla-central/rev/307f90b2422f

Comment 12

[Barbara Bermes [:barbara] - NI please!]

Release Note Request (optional, but appreciated)
[Why is this notable]: Added preference under Settings-Advanced to enable/disable web fonts
[Suggested wording]: Add "Show/Hide web fonts" in advanced settings to reduce bandwidth and data
[Links (documentation, blog post, etc)]:

Comment 13

[u421692]

Verified as fixed on latest Nightly on Samsung Galaxy S5 (Android 5.0)
The "Show web fonts" option is available under Advanced menu.
Verified that it works on https://www.google.com/fonts

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Fx47 (Aurora) release notes.