1249526 - Beetmove missing files

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, defect)

Description

[Rail Aliiev [:rail]]

* SDK
* martools
* jsshell

Anything else?

they are all generated by en-US builds, just need to be copied to the candidates directory.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1249526.patch

testing on all platforms on my docker image

Comment 2

[Kim Moir [:kmoir] ET]

previous comment should have said tested not testing

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8722598 [details] [diff] [review]
bug1249526.patch

Review of attachment 8722598 [details] [diff] [review]:
-----------------------------------------------------------------

Some nits:

::: testing/mozharness/configs/beetmover/en_us.yml.tmpl
@@ +44,5 @@
>        artifact: {{ artifact_base_url }}/firefox-{{ app_version }}.{{ locale }}.{{ platform }}_info.txt
>        s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/win32_info.txt
> +    sdk:
> +      artifact: {{ artifact_base_url }}/firefox-{{ app_version }}.{{ locale }}.{{ platform }}.sdk.zip
> +      s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/firefox-{{ app_version }}.i{{ locale }}.{{ platform }}.sdk.zip

typo: i{{ locale }}

@@ +47,5 @@
> +      artifact: {{ artifact_base_url }}/firefox-{{ app_version }}.{{ locale }}.{{ platform }}.sdk.zip
> +      s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/firefox-{{ app_version }}.i{{ locale }}.{{ platform }}.sdk.zip
> +    jsshell:
> +      artifact: {{ artifact_base_url }}/jsshell-{{ platform }}.zip
> +      s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/jsshell-{{ platform }}.zip

Looks like jsshell is the same for all platforms, you can move it to the common section, just below "socorroinfo".

@@ +50,5 @@
> +      artifact: {{ artifact_base_url }}/jsshell-{{ platform }}.zip
> +      s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/jsshell-{{ platform }}.zip
> +    mar_tools_mar:
> +      artifact: {{ artifact_base_url }}/mar.exe
> +      s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/mar-tools/{{ platform }}/mar.exe

Looks like we use "buildbot" platform names at http://ftp.mozilla.org/pub/firefox/candidates/45.0b6-candidates/build1/mar-tools/. You can't use {{ platform }} in s3_key in this case. Just use explicit platform names, just like in buildid_info

@@ +53,5 @@
> +      artifact: {{ artifact_base_url }}/mar.exe
> +      s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/mar-tools/{{ platform }}/mar.exe
> +    mar_tools_mbdiff:
> +      artifact: {{ artifact_base_url }}/mbsdiff.exe
> +      s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/mar-tools/{{ platform }}/mbsdiff.exe

the same here

Comment 4

[Kim Moir [:kmoir] ET]

Attachment: bug1249526-2.patch

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 8722647 [details] [diff] [review]
bug1249526-2.patch

Review of attachment 8722647 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/mozharness/configs/beetmover/en_us.yml.tmpl
@@ +47,5 @@
>        artifact: {{ artifact_base_url }}/firefox-{{ app_version }}.{{ locale }}.{{ platform }}_info.txt
>        s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/win32_info.txt
> +    sdk:
> +      artifact: {{ artifact_base_url }}/firefox-{{ app_version }}.{{ locale }}.{{ platform }}.sdk.zip
> +      s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/firefox-{{ app_version }}.{{ locale }}.{{ platform }}.sdk.zip

Hmm, I wonder if we want these to go under $platform/en-US directory...
something like

 s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/{{ platform }}/{{ locale }}/firefox-{{ app_version }}.sdk.zip

And the same for other platforms...

@@ +113,5 @@
>        artifact: {{ artifact_base_url }}/firefox-{{ app_version }}.{{ locale }}.{{ platform }}_info.txt
>        s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/linux64_info.txt
> +    sdk:
> +      artifact: {{ artifact_base_url }}/firefox-{{ app_version }}.{{ locale }}.{{ platform }}.sdk.tar.bz2
> +      s3_key: {{ s3_prefix }}/{{ version }}-candidates/{{ build_num }}/.firefox-{{ app_version }}.{{ locale }}.{{ platform }}.sdk.tar.bz2

Typo: ".firefox-"

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 8722647 [details] [diff] [review]
bug1249526-2.patch

Review of attachment 8722647 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the typo fixed.

Comment 7

[Kim Moir [:kmoir] ET]

Attachment: bug1249526-3.patch

patch with typo fixed

Comment 8

[Kim Moir [:kmoir] ET]

verified that files were moved in https://tools.taskcluster.net/task-graph-inspector/#atRXKAWBSb2dAVf6Ydz0Ag/9fjK3nL-SyiNH6L3H8wVkA/

Comment 9

[Rail Aliiev [:rail]]

Attachment: linux_missing.diff

I just verified that everything works as expected, just need to adjust linux32 to match other platforms.

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0db0d77b32a9

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0db0d77b32a9