Closed
Bug 1249534
Opened 8 years ago
Closed 8 years ago
Cannot unpin Marketplace content from Home successfully.
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(blocking-b2g:2.5+, b2g-v2.5 verified, b2g-master verified)
VERIFIED
FIXED
blocking-b2g | 2.5+ |
People
(Reporter: cindylee, Assigned: rexboy)
References
()
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
46 bytes,
text/x-github-pull-request
|
lchang
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
[Description] Cannot unpin Marketplace content from Home successfully. [Test Steps] 1. Launch Apps. 2. Navigate to Marketplace content which is pinned to home. 3. Press "option" button. 4. Choose "Unpin from Home". 5. Press "Home" button. 6. Observe the behavior. 7. The unpinned Marketplace content still shows on Home page. [Expected Result] 7. The unpinned Marketplace content should disappear on Home page. [Actual Result] 7. The unpinned Marketplace content still shows on Home page. (Please refer to: https://youtu.be/uyZ17TojnJQ) [Frequency] 5/5 [TCID] 17952 [Build Info] Environment: 2.6 Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/d7de878f60003244cf91046cafe06c1b6cd6ecc9 gecko: https://hg.mozilla.org/mozilla-central/rev/fcd35e10fa17d9fd11d92be48ae9698c2a900f1c
Comment 2•8 years ago
|
||
Hi Cindy, please help to check if v2.5 also has this issue or not, thanks.
Flags: needinfo?(cindylee)
Keywords: qawanted
(In reply to Mike Lien[:mlien] from comment #2) > Hi Cindy, please help to check if v2.5 also has this issue or not, thanks. Hi Mike, This issue is also observed on v2.5 latest build. [Build Info] gaia: https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393 gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/38e6a8bdf412a947418ffffc54c4821fe6103f9f mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3
Flags: needinfo?(cindylee)
status-b2g-v2.5:
--- → affected
Keywords: qawanted
Comment 4•8 years ago
|
||
[Blocking Requested - why for this release]: Basic function broken
blocking-b2g: 2.6? → 2.5?
Updated•8 years ago
|
Assignee: nobody → rexboy
blocking-b2g: 2.5? → 2.5+
Assignee | ||
Comment 6•8 years ago
|
||
It's a regression of bug 1246090. My bad :-/
Comment 7•8 years ago
|
||
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8724012 [details] [review] [gaia] rexboy7:1249534-unpin-bookmark-regression > mozilla-b2g:master Luke may you review this patch?
Flags: needinfo?(rexboy)
Attachment #8724012 -
Flags: review?(lchang)
Comment 9•8 years ago
|
||
Comment on attachment 8724012 [details] [review] [gaia] rexboy7:1249534-unpin-bookmark-regression > mozilla-b2g:master Looks good!
Attachment #8724012 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 10•8 years ago
|
||
master https://github.com/mozilla-b2g/gaia/commit/78a670b73b4ddc250abd4e2bbaae8cfda31f8287
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•8 years ago
|
||
Comment on attachment 8724012 [details] [review] [gaia] rexboy7:1249534-unpin-bookmark-regression > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): regression of bug 1246090 [User impact] if declined: defeat on pin to home feature [Testing completed]: done on local [Risk to taking this patch] (and alternatives if risky): small [String changes made]: none
Attachment #8724012 -
Flags: approval-gaia-v2.5?
Reporter | ||
Comment 12•8 years ago
|
||
This issue is fixed on v2.6 but it's still observed on v2.5. [Build Info] gaia: https://github.com/mozilla-b2g/gaia/commit/bae79910eb2f3b1a657a40fcd5def0a898214d17 gecko: https://hg.mozilla.org/mozilla-central/rev/bdde3fedb45be528f985a0aff373b37b010fb927
Updated•8 years ago
|
Comment 13•8 years ago
|
||
Comment on attachment 8724012 [details] [review] [gaia] rexboy7:1249534-unpin-bookmark-regression > mozilla-b2g:master Approve for TV 2.5
Attachment #8724012 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Updated•8 years ago
|
Blocks: TV_Marketplace_2.5
Comment 14•8 years ago
|
||
Hi Rex, this patch still doesn't uplift to v2.5, please help it, thanks.
Flags: needinfo?(rexboy)
Assignee | ||
Comment 15•8 years ago
|
||
v2.5 https://github.com/mozilla-b2g/gaia/commit/737598bdc2c429342b3102b3a5f3e3bf486e8775
Flags: needinfo?(rexboy)
Reporter | ||
Comment 16•8 years ago
|
||
This issue is verified on v2.5 latest build. [Build Info] gaia: https://github.com/mozilla-b2g/gaia/commit/737598bdc2c429342b3102b3a5f3e3bf486e8775 gecko: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/f1bcda18c55d891616944f7bfafb33c3b76a1fc3 mulet: https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3
You need to log in
before you can comment on or make changes to this bug.
Description
•