1249590 - Make AsyncShutdown more resilient to exceptions

Status: RESOLVED FIXED

(Toolkit :: Async Tooling, defect)

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: Bug 1249590 - Bullet-proofing AsyncShutdown wrt exceptions;r?froydnj

While investigating bug 1248489, we discovered that some code paths in
AsyncShutdown could possibly be sensitive to exceptions being thrown
in unexpected places. This patch attempts to make AsyncShutdown more
robust to such exceptions.

Review commit: https://reviewboard.mozilla.org/r/35631/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35631/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8721292 [details]
MozReview Request: Bug 1249590 - Bullet-proofing AsyncShutdown wrt exceptions;r?froydnj

https://reviewboard.mozilla.org/r/35631/#review32301

This patch is basically what I expected it to be from the description, which is good. :)

::: toolkit/components/asyncshutdown/AsyncShutdown.jsm:541
(Diff revision 1)
> +      debug("Error in nsIObserve.observe");

Nit: maybe something like "Error waiting for the barrier" or somesuch?

::: toolkit/components/asyncshutdown/AsyncShutdown.jsm:693
(Diff revision 1)
>          throw new Error(`Phase "${ this._name } is finished, it is too late to register completion condition "${ name }"`);

Nit: The first ${ this._name } is missing a closing double-quote.

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8721292 [details]
MozReview Request: Bug 1249590 - Bullet-proofing AsyncShutdown wrt exceptions;r?froydnj

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35631/diff/1-2/

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a336fe9269c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3a336fe9269c