Closed Bug 1249594 Opened 4 years ago Closed 4 years ago

Show name of organization (EV certificate) in URL bar

Categories

(Firefox for Android :: Awesomescreen, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 47
Tracking Status
firefox47 --- verified
firefox48 --- verified
relnote-firefox --- 47+

People

(Reporter: sebastian, Assigned: sebastian)

References

Details

Attachments

(2 files)

In bug 1236431 we have been thinking about displaying the organization (e.g. "Mozilla Foundation") in the URL bar if the website has an EV certificate.
Attached image urlbar_owner.png
This is a screenshot of a WIP patch that shows the certificate owner + country in the URLbar if available.
Attachment #8721775 - Flags: feedback?(alam)
How are we going to deal with truncation of the organization name? They can be up to 64 characters.
Comment on attachment 8721775 [details]
urlbar_owner.png

Looks good to me!
Attachment #8721775 - Flags: feedback?(alam) → feedback+
(In reply to Kevin Brosnan [:kbrosnan] from comment #2)
> How are we going to deal with truncation of the organization name? They can
> be up to 64 characters.

This is an edge case to me that affects any decision we make here anyways. I don't think there's any huge concern here with this. It's still a nice little added verification we can make for EV certs.
Assignee: nobody → s.kaspari
Comment on attachment 8722754 [details]
MozReview Request: Bug 1249594 - Show name of owner (EV certificate) in URL bar if available. r=mcomella

https://reviewboard.mozilla.org/r/35773/#review33877

::: mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarDisplayLayout.java:283
(Diff revision 1)
> +            spannable.setSpan(new ForegroundColorSpan(color), 0, title.length(), Spannable.SPAN_EXCLUSIVE_EXCLUSIVE);

nit: Do you think it might be worth re-using the `ForegroundColorSpan` (if we can)? It sucks to create a new object each time (though we do it for the `SpannableString` so /shrug).

::: mobile/android/base/resources/values/colors.xml:115
(Diff revision 1)
> +  <color name="url_bar_certificate_owner">#6fbe4a</color>

This is already `@color/affirmative_green`

::: mobile/android/chrome/content/browser.js:6447
(Diff revision 1)
>        if (iData.state && iData.country)

We should add `result.country` here too, right?
Attachment #8722754 - Flags: review?(michael.l.comella) → review+
(In reply to Michael Comella (:mcomella) from comment #6)
> ::: mobile/android/chrome/content/browser.js:6447
> (Diff revision 1)
> >        if (iData.state && iData.country)
> 
> We should add `result.country` here too, right?

You are absolutely correct and what's even worse: Those if/else statements do not have any braces and currently my code is executed always. This is a good example of why this is problematic. Especially if you write Python every now and then this looks like valid code. :)
https://reviewboard.mozilla.org/r/35773/#review33877

> nit: Do you think it might be worth re-using the `ForegroundColorSpan` (if we can)? It sucks to create a new object each time (though we do it for the `SpannableString` so /shrug).

I don't think it's worth having the additional code and keeping the span in memory. We are not updating the title that often and most of the sites do not have an EV certificate anyways.
Comment on attachment 8722754 [details]
MozReview Request: Bug 1249594 - Show name of owner (EV certificate) in URL bar if available. r=mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35773/diff/1-2/
Attachment #8722754 - Attachment description: MozReview Request: Bug 1249594 - Show name of owner (EV certificate) in URL bar if available. r?mcomella → MozReview Request: Bug 1249594 - Show name of owner (EV certificate) in URL bar if available. r=mcomella
https://hg.mozilla.org/integration/fx-team/rev/e082689e684d1bac1255f29786befe907fbf5942
Bug 1249594 - Show name of owner (EV certificate) in URL bar if available. r=mcomella
https://hg.mozilla.org/mozilla-central/rev/e082689e684d
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Verified as fixed in builds:
- 48.0a1 2016-03-10;
- 47.0a2 2016-03-11;
Device: Nexus 5 (Android 6.0.1).
Status: RESOLVED → VERIFIED
Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: Show name of organization (EV certificate) in URL bar
[Links (documentation, blog post, etc)]:
relnote-firefox: --- → ?
Added to Fx47 (beta) release notes.
isnt the way it is dont a bit overkill? since the URL is now completely hidden?
See Also: → 1268753
How do you disable this anti-feature?
or at least make it less prominent (e.g. by modifying the lock icons, like adding a tick to it or whatever ot just making it grey again.)
These settings break EV and restore the url to its rightful place.

security.ssl.enable_ocsp_stapling = false
security.OCSP.enabled = 0
well breaking EV isnt what I think should be done, just instead add a more subtle way to distinguish EV from non-EV for example making non-EV gray again, even edge is going that way and it's good in my opinion, that way, ppl who kow their stuff can hide the company to get space and still see whether EV or not (and with a small popup at the first start even not so techy users could be teached.
Bug 1268753 was filed for providing a way to change the display. We have not had any discussion about this yet.
You need to log in before you can comment on or make changes to this bug.