1249594 - Show name of organization (EV certificate) in URL bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Sebastian Kaspari (:sebastian; :pocmo)]

In bug 1236431 we have been thinking about displaying the organization (e.g. "Mozilla Foundation") in the URL bar if the website has an EV certificate.

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: urlbar_owner.png

This is a screenshot of a WIP patch that shows the certificate owner + country in the URLbar if available.

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

How are we going to deal with truncation of the organization name? They can be up to 64 characters.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Comment on attachment 8721775 [details]
urlbar_owner.png

Looks good to me!

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Kevin Brosnan [:kbrosnan] from comment #2)
> How are we going to deal with truncation of the organization name? They can
> be up to 64 characters.

This is an edge case to me that affects any decision we make here anyways. I don't think there's any huge concern here with this. It's still a nice little added verification we can make for EV certs.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1249594 - Show name of owner (EV certificate) in URL bar if available. r=mcomella

Review commit: https://reviewboard.mozilla.org/r/35773/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35773/

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8722754 [details]
MozReview Request: Bug 1249594 - Show name of owner (EV certificate) in URL bar if available. r=mcomella

https://reviewboard.mozilla.org/r/35773/#review33877

::: mobile/android/base/java/org/mozilla/gecko/toolbar/ToolbarDisplayLayout.java:283
(Diff revision 1)
> +            spannable.setSpan(new ForegroundColorSpan(color), 0, title.length(), Spannable.SPAN_EXCLUSIVE_EXCLUSIVE);

nit: Do you think it might be worth re-using the `ForegroundColorSpan` (if we can)? It sucks to create a new object each time (though we do it for the `SpannableString` so /shrug).

::: mobile/android/base/resources/values/colors.xml:115
(Diff revision 1)
> +  <color name="url_bar_certificate_owner">#6fbe4a</color>

This is already `@color/affirmative_green`

::: mobile/android/chrome/content/browser.js:6447
(Diff revision 1)
>        if (iData.state && iData.country)

We should add `result.country` here too, right?

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

(In reply to Michael Comella (:mcomella) from comment #6)
> ::: mobile/android/chrome/content/browser.js:6447
> (Diff revision 1)
> >        if (iData.state && iData.country)
> 
> We should add `result.country` here too, right?

You are absolutely correct and what's even worse: Those if/else statements do not have any braces and currently my code is executed always. This is a good example of why this is problematic. Especially if you write Python every now and then this looks like valid code. :)

Comment 8

[Sebastian Kaspari (:sebastian; :pocmo)]

https://reviewboard.mozilla.org/r/35773/#review33877

> nit: Do you think it might be worth re-using the `ForegroundColorSpan` (if we can)? It sucks to create a new object each time (though we do it for the `SpannableString` so /shrug).

I don't think it's worth having the additional code and keeping the span in memory. We are not updating the title that often and most of the sites do not have an EV certificate anyways.

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8722754 [details]
MozReview Request: Bug 1249594 - Show name of owner (EV certificate) in URL bar if available. r=mcomella

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35773/diff/1-2/

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/e082689e684d1bac1255f29786befe907fbf5942
Bug 1249594 - Show name of owner (EV certificate) in URL bar if available. r=mcomella

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e082689e684d

Comment 12

[Flaviu Cos]

Verified as fixed in builds:
- 48.0a1 2016-03-10;
- 47.0a2 2016-03-11;
Device: Nexus 5 (Android 6.0.1).

Comment 13

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Suggested wording]: Show name of organization (EV certificate) in URL bar
[Links (documentation, blog post, etc)]:

Comment 14

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Fx47 (beta) release notes.

Comment 15

[My1]

isnt the way it is dont a bit overkill? since the URL is now completely hidden?

Comment 16

[adria]

How do you disable this anti-feature?

Comment 17

[My1]

or at least make it less prominent (e.g. by modifying the lock icons, like adding a tick to it or whatever ot just making it grey again.)

Comment 18

[adria]

These settings break EV and restore the url to its rightful place.

security.ssl.enable_ocsp_stapling = false
security.OCSP.enabled = 0

Comment 19

[My1]

well breaking EV isnt what I think should be done, just instead add a more subtle way to distinguish EV from non-EV for example making non-EV gray again, even edge is going that way and it's good in my opinion, that way, ppl who kow their stuff can hide the company to get space and still see whether EV or not (and with a small popup at the first start even not so techy users could be teached.

Comment 20

[Kevin Brosnan [Ex-Mozilla]]

Bug 1268753 was filed for providing a way to change the display. We have not had any discussion about this yet.