1249738 - get rid of the static constructor for hal/Hal.cpp

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Trevor Saunders (:tbsaunde)]

making the ctors for the static objects in this file constexpr is awkward because we'd need to make a static TArray class.  So it seems easier to hide the statics inside functions that lazily create them when needed and return
 a reference to them.  An additional benefit of doing this is that we can make sure all accesses to the object happen on the main thread. Please enter the summary (first line) and description (other lines). Lines

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: make sBatteryObservers a function static

Comment 2

[Trevor Saunders (:tbsaunde)]

Attachment: make sNetworkObservers a function static

Comment 3

[Trevor Saunders (:tbsaunde)]

Attachment: make sScreenConfigurationObservers a function static

Comment 4

[Trevor Saunders (:tbsaunde)]

Attachment: make sWakeLockObservers a function static

Comment 5

[Trevor Saunders (:tbsaunde)]

Attachment: make sSystemClockChangeObservers a function static

Comment 6

[Trevor Saunders (:tbsaunde)]

Attachment: make sSystemTimezoneChangeObservers a function static

Comment 7

[Dave Hylands [:dhylands]]

Comment on attachment 8721413 [details] [diff] [review]
make sBatteryObservers a function static

Review of attachment 8721413 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 8

[Dave Hylands [:dhylands]]

Comment on attachment 8721418 [details] [diff] [review]
make sSystemTimezoneChangeObservers a function static

Review of attachment 8721418 [details] [diff] [review]:
-----------------------------------------------------------------

I like the main-thread check (for all of these). Excellent.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/73c742908f3f
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e27306cd8fb
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b7370854a0b
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f8651cfdccb
https://hg.mozilla.org/integration/mozilla-inbound/rev/53d07f5c025b
https://hg.mozilla.org/integration/mozilla-inbound/rev/a871b30278aa

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/73c742908f3f
https://hg.mozilla.org/mozilla-central/rev/5e27306cd8fb
https://hg.mozilla.org/mozilla-central/rev/4b7370854a0b
https://hg.mozilla.org/mozilla-central/rev/0f8651cfdccb
https://hg.mozilla.org/mozilla-central/rev/53d07f5c025b
https://hg.mozilla.org/mozilla-central/rev/a871b30278aa