1249795 - Clear strong refs to message managers once we've destroyed nsFrameLoader

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: clear_mm.diff

Destroying frameloader does clear references like mDocShell, but we keep message managers alive, even though we've called Disconnect() on them.

There are cases when JS keeps nsFrameLoader objects alive too long, which leads to keeping 
also other stuff alive too long.

This is possibly helping with bug 1195295.

I think I need to do a try: -a with the patch though.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

(and I want to clear them both after they both have been disconnected.)

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: clear_mm.diff

same without some windows line endings which pastebin decided to add to the patch.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4751f0a01194

(hopefully the patch I just landed to m-i doesn't burn the tree)

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8721515 [details] [diff] [review]
clear_mm.diff

Review of attachment 8721515 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense to me. Thanks for looking into this, smaug!

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/443a0e286032

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/443a0e286032