1249824 - graphite2: crash around null in [@graphite2::SlotMap::collectGarbage] Pass.cpp:654

Status: RESOLVED FIXED

(Core :: Graphics: Text, defect)

Description

[Tyson Smith [:tsmith]]

Attachment: test_case.ttf

This was found while fuzzing graphite2 revision c8450dbaa160be5c939d9abb5cfe01284e22b45f

==30019==ERROR: AddressSanitizer: SEGV on unknown address 0x00000000006c (pc 0x7f3ca4966a77 bp 0x7ffe618e23d0 sp 0x7ffe618e22c0 T0)
    #0 0x7f3ca4966a76 in graphite2::Slot::isDeleted() const /home/user/code/graphite/src/inc/Slot.h:101:38
    #1 0x7f3ca4966a76 in graphite2::SlotMap::collectGarbage(graphite2::Slot*&) /home/user/code/graphite/src/Pass.cpp:654
    #2 0x7f3ca4966a76 in graphite2::Pass::findNDoRule(graphite2::Slot*&, graphite2::vm::Machine&, graphite2::FiniteStateMachine&) const /home/user/code/graphite/src/Pass.cpp:544
    #3 0x7f3ca4964d06 in graphite2::Pass::runGraphite(graphite2::vm::Machine&, graphite2::FiniteStateMachine&, bool) const /home/user/code/graphite/src/Pass.cpp:412:13
    #4 0x7f3ca49802da in graphite2::Silf::runGraphite(graphite2::Segment*, unsigned char, unsigned char, int) const /home/user/code/graphite/src/Silf.cpp:423:21
    #5 0x7f3ca493efe8 in graphite2::Face::runGraphite(graphite2::Segment*, graphite2::Silf const*) const /home/user/code/graphite/src/Face.cpp:180:16
    #6 0x7f3ca490e27f in graphite2::Segment::runGraphite() /home/user/code/graphite/src/inc/Segment.h:97:45
    #7 0x7f3ca490e27f in (anonymous namespace)::makeAndInitialize(graphite2::Font const*, graphite2::Face const*, unsigned int, graphite2::FeatureVal const*, gr_encform, void const*, unsigned long, int) /home/user/code/graphite/src/gr_segment.cpp:46
    #8 0x7f3ca490e27f in gr_make_seg /home/user/code/graphite/src/gr_segment.cpp:105
    #9 0x4ee329 in Gr2Renderer::renderText(char const*, unsigned long, RenderedLine*, _IO_FILE*) /home/user/code/graphite/tests/comparerenderer/Gr2Renderer.h:103:28
    #10 0x4ef2b3 in CompareRenderer::runRenderer(Renderer&, RenderedLine*, unsigned long&, _IO_FILE*) /home/user/code/graphite/tests/comparerenderer/CompareRenderer.cpp:213:17
    #11 0x4e6520 in CompareRenderer::runTests(_IO_FILE*, int) /home/user/code/graphite/tests/comparerenderer/CompareRenderer.cpp:126:41
    #12 0x4e6520 in main /home/user/code/graphite/tests/comparerenderer/CompareRenderer.cpp:382
    #13 0x7f3ca434aec4 in __libc_start_main /build/eglibc-3GlaMS/eglibc-2.19/csu/libc-start.c:287
    #14 0x41bd6c in _start (/home/user/Desktop/graphite/comparerenderer+0x41bd6c)

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV /home/user/code/graphite/src/inc/Slot.h:101:38 in graphite2::Slot::isDeleted() const

Comment 1

[Tyson Smith [:tsmith]]

Attachment: test_string.txt

Comment 2

[Tyson Smith [:tsmith]]

Verified with graphite revision fb32e2e39ccd0980672f55052f75fc10f8736fb2