Closed
Bug 1249827
Opened 9 years ago
Closed 9 years ago
Autophone - disable switchboard network access in Autophone
Categories
(Testing Graveyard :: Autophone, defect)
Testing Graveyard
Autophone
Tracking
(firefox47 affected)
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | affected |
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
|
1.67 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
bug 1247324 introduced an environment variable to disable switchboard network access. We need to incorporate that into autophone.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8721551 -
Flags: review?(gbrown)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8721551 [details] [diff] [review]
bug-1249827-v1.patch
Review of attachment 8721551 [details] [diff] [review]:
-----------------------------------------------------------------
::: tests/robotest.py
@@ +77,5 @@
> + env_vars = {
> + 'MOZ_CRASHREPORTER': 1,
> + 'MOZ_CRASHREPORTER_NO_REPORT': 1,
> + 'MOZ_CRASHREPORTER_SHUTDOWN': 1,
> + 'MOZ_DISABLE_NONLOCAL_CONNECTIONS': '1',
You added MOZ_DISABLE_NONLOCAL_CONNECTIONS, but still have a note below saying that's disabled!
Attachment #8721551 -
Flags: review?(gbrown) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
Thanks for catching that robotest thing.
https://github.com/mozilla/autophone/commit/a2b4a7db1544d6a9dd757b6f45d555186acbbd48
deployed 2016-02-19 16:12
|
||
Updated•3 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•