1249860 - Add simulcast test for resolution scaling

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P1)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Follow-up from Bug 1244913 comment 30.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: MozReview Request: Bug 1249860 - Add simulcast test for resolution scaling.

Review commit: https://reviewboard.mozilla.org/r/35751/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35751/

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=46a5cfabed83

Comment 3

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8721612 [details]
MozReview Request: Bug 1249860 - Add simulcast test for resolution scaling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35751/diff/1-2/

Comment 4

[Byron Campen [:bwc]]

Comment on attachment 8721612 [details]
MozReview Request: Bug 1249860 - Add simulcast test for resolution scaling.

https://reviewboard.mozilla.org/r/35751/#review32465

::: dom/media/tests/mochitest/test_peerConnection_simulcastOffer.html:134
(Diff revision 2)
>          function PC_REMOTE_WAIT_FOR_COLOR_CHANGE_2() {
> +          var vlocal = document.getElementById('pcLocal_local1_video');
>            var vremote = document.getElementById('pcRemote_remote1_video');
> +          ok(vlocal, "Should have local video element for pcLocal");
>            ok(vremote, "Should have remote video element for pcRemote");
> +          ok(vlocal.videoWidth > 0, "source width is positive");
> +          ok(vlocal.videoHeight > 0, "source height is positive");
> +          is(vremote.videoWidth, vlocal.videoWidth / 2, "sink is 1/2 width of source");
> +          is(vremote.videoHeight, vlocal.videoHeight / 2,  "sink is 1/2 height of source");
>            return waitForColorChange(helper, vremote);
>          },

You probably want to put this stuff in a separate step, since the size isn't going to be guaranteed to change until after we've observed the color change.

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 8721612 [details]
MozReview Request: Bug 1249860 - Add simulcast test for resolution scaling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35751/diff/2-3/

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Incorporated feedback in comment 4. Carrying forward r=bwc.

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Green try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9289a93c2015

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf777813f723

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cf777813f723