Closed Bug 1249860 Opened 4 years ago Closed 4 years ago

Add simulcast test for resolution scaling

Categories

(Core :: WebRTC, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed
Blocking Flags:

People

(Reporter: jib, Assigned: jib)

References

Details

Attachments

(1 file)

Assignee: nobody → jib
Comment on attachment 8721612 [details]
MozReview Request: Bug 1249860 - Add simulcast test for resolution scaling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35751/diff/1-2/
Comment on attachment 8721612 [details]
MozReview Request: Bug 1249860 - Add simulcast test for resolution scaling.

https://reviewboard.mozilla.org/r/35751/#review32465

::: dom/media/tests/mochitest/test_peerConnection_simulcastOffer.html:134
(Diff revision 2)
>          function PC_REMOTE_WAIT_FOR_COLOR_CHANGE_2() {
> +          var vlocal = document.getElementById('pcLocal_local1_video');
>            var vremote = document.getElementById('pcRemote_remote1_video');
> +          ok(vlocal, "Should have local video element for pcLocal");
>            ok(vremote, "Should have remote video element for pcRemote");
> +          ok(vlocal.videoWidth > 0, "source width is positive");
> +          ok(vlocal.videoHeight > 0, "source height is positive");
> +          is(vremote.videoWidth, vlocal.videoWidth / 2, "sink is 1/2 width of source");
> +          is(vremote.videoHeight, vlocal.videoHeight / 2,  "sink is 1/2 height of source");
>            return waitForColorChange(helper, vremote);
>          },

You probably want to put this stuff in a separate step, since the size isn't going to be guaranteed to change until after we've observed the color change.
Attachment #8721612 - Flags: review?(docfaraday) → review+
backlog: --- → webrtc/webaudio+
Rank: 15
Priority: -- → P1
Comment on attachment 8721612 [details]
MozReview Request: Bug 1249860 - Add simulcast test for resolution scaling.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35751/diff/2-3/
Incorporated feedback in comment 4. Carrying forward r=bwc.
https://hg.mozilla.org/mozilla-central/rev/cf777813f723
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.