Closed Bug 1249880 Opened 4 years ago Closed 4 years ago

non-e10s generating content process crash reports

Categories

(Core :: DOM: Content Processes, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX
Tracking Status
e10s ? ---
firefox47 --- affected

People

(Reporter: jonathan, Unassigned)

References

Details

(Whiteboard: btpp-followup-2016-03-01)

I spotted this which looks to be using the wrong argument. Not investigated further.
https://dxr.mozilla.org/mozilla-central/source/dom/ipc/CrashReporterParent.cpp#63
Also, note that non-e10s builds actually do have content processes for thumbnailing.
(In reply to Jonathan Howard from comment #1)
> I spotted this which looks to be using the wrong argument. Not investigated
> further.
> https://dxr.mozilla.org/mozilla-central/source/dom/ipc/CrashReporterParent.
> cpp#63

Yeah, that is wrong. It's not used by desktop Firefox though.
I strongly suspect thumbnailing for this, and the limited evidence backs this up: there is no visible way to submit thumbnail content process crashes: you'd have to visit about:crashes to submit them. That's why they show up much higher in telemetry than in crash-stats.

Without more data, I'm not sure what to make of this. We always treated this as low-priority in the past, because a failed thumbnail is just not a big deal.

With e10s enabled, are these thumbnails still in a separate process from the "main" e10s content process? If not, and fiven that e10s is coming, perhaps we should just WONTFIX this?
Flags: needinfo?(markh)
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #4)
> I strongly suspect thumbnailing for this, and the limited evidence backs
> this up: there is no visible way to submit thumbnail content process
> crashes: you'd have to visit about:crashes to submit them. That's why they
> show up much higher in telemetry than in crash-stats.

There is explicit handling for process crashing at https://dxr.mozilla.org/mozilla-central/rev/789a12291942763bc1e3a89f97e0b82dc1c9d00b/toolkit/components/thumbnails/BackgroundPageThumbs.jsm#193, so it should be easy to add telemetry or some other action around these crashes if we care enough.

> With e10s enabled, are these thumbnails still in a separate process from the
> "main" e10s content process? If not, and fiven that e10s is coming, perhaps
> we should just WONTFIX this?

I believe it is the same process - we just create a <browser type="content" remote="true"/> which IIUC will end up in the single e10s process.
Flags: needinfo?(markh)
tracking-e10s: --- → ?
We discussed splitting thumbnailing out in bug 1187441 - Use separate content processes for e10s browsing and thumbnail generation.
Depends on: 1187441
Should we leave this open?
Component: IPC → DOM: Content Processes
Flags: needinfo?(benjamin)
Whiteboard: btpp-followup-2016-03-01
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(benjamin)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.