1249893 - Refresh the inspector sidebar's input bar

Status: NEW

(DevTools :: Inspector, defect, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

We should refresh the rule/computed/font view's input bar to match what we see in Helen's design https://projects.invisionapp.com/share/9G5R8XCYZ#/screens/117937553

Comment 1

[Tim Nguyen :ntim]

(In reply to Gabriel Luong [:gl] (ΦωΦ) from comment #0)
> We should refresh the rule/computed/font view's input bar to match what we
> see in Helen's design
> https://projects.invisionapp.com/share/9G5R8XCYZ#/screens/117937553

Not sure how it should look for the dark theme. Probably a bit odd.

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1249893.patch

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Need a new 'x' icon as discussed.

Comment 4

[Helen V. Holmes (:helenvholmes) (:✨)]

Attachment: close.svg

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1249893.patch [wip]

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Hi Tim, 

I notice that there is a new 'x' icon for devtools which is similar to permission panel used. Bug 1203292 will introduce a new 'x' for permission panel which also I'm working on. I suspect that it will be landed in next week.
I don't know whether we are able to reused it but just want to inform you this information here.

Comment 7

[[e-mail]]

Gabriel does this work will be happened soon? Or could we just start convert searchbar to html in bug 1265759? (the bug is included in track #2 issue list)

Comment 8

[Tim Nguyen :ntim]

(In reply to Ricky Chien [:rickychien] from comment #6)
> Hi Tim, 
> 
> I notice that there is a new 'x' icon for devtools which is similar to
> permission panel used. Bug 1203292 will introduce a new 'x' for permission
> panel which also I'm working on. I suspect that it will be landed in next
> week.
> I don't know whether we are able to reused it but just want to inform you
> this information here.

Feel free to reuse it.

Comment 9

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Fred Lin [:gasolin] from comment #7)
> Gabriel does this work will be happened soon? Or could we just start convert
> searchbar to html in bug 1265759? (the bug is included in track #2 issue
> list)

Hi Fred,

If the goal of Bug 1265759 is to create a search bar widget component, then I would say go ahead. I am mainly curious because this bug only affects the sidebar input toolbar, which are already in HTML for the Inspector. So, can you clarify what work will be done?

Comment 10

[[e-mail]]

Thanks for update, my plan is only convert the inspector main search box (from xul textbox to html:input) in bug 1265759, so its not affect the sidebar input toolbar.