Refresh the inspector sidebar's input bar

NEW
Unassigned

Status

P3
normal
3 years ago
5 months ago

People

(Reporter: gl, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
We should refresh the rule/computed/font view's input bar to match what we see in Helen's design https://projects.invisionapp.com/share/9G5R8XCYZ#/screens/117937553
(In reply to Gabriel Luong [:gl] (ΦωΦ) from comment #0)
> We should refresh the rule/computed/font view's input bar to match what we
> see in Helen's design
> https://projects.invisionapp.com/share/9G5R8XCYZ#/screens/117937553

Not sure how it should look for the dark theme. Probably a bit odd.
(Reporter)

Comment 2

3 years ago
Created attachment 8721880 [details] [diff] [review]
1249893.patch
Priority: -- → P3
(Reporter)

Comment 3

3 years ago
Need a new 'x' icon as discussed.
Flags: needinfo?(hholmes)
Created attachment 8722100 [details]
close.svg
Flags: needinfo?(hholmes)
(Reporter)

Comment 5

2 years ago
Created attachment 8767675 [details] [diff] [review]
1249893.patch [wip]
Attachment #8721880 - Attachment is obsolete: true

Updated

2 years ago
Blocks: 1265759
Hi Tim, 

I notice that there is a new 'x' icon for devtools which is similar to permission panel used. Bug 1203292 will introduce a new 'x' for permission panel which also I'm working on. I suspect that it will be landed in next week.
I don't know whether we are able to reused it but just want to inform you this information here.
Flags: needinfo?(ntim.bugs)

Comment 7

2 years ago
Gabriel does this work will be happened soon? Or could we just start convert searchbar to html in bug 1265759? (the bug is included in track #2 issue list)
Flags: needinfo?(gl)
(In reply to Ricky Chien [:rickychien] from comment #6)
> Hi Tim, 
> 
> I notice that there is a new 'x' icon for devtools which is similar to
> permission panel used. Bug 1203292 will introduce a new 'x' for permission
> panel which also I'm working on. I suspect that it will be landed in next
> week.
> I don't know whether we are able to reused it but just want to inform you
> this information here.

Feel free to reuse it.
Flags: needinfo?(ntim.bugs)
(Reporter)

Comment 9

2 years ago
(In reply to Fred Lin [:gasolin] from comment #7)
> Gabriel does this work will be happened soon? Or could we just start convert
> searchbar to html in bug 1265759? (the bug is included in track #2 issue
> list)

Hi Fred,

If the goal of Bug 1265759 is to create a search bar widget component, then I would say go ahead. I am mainly curious because this bug only affects the sidebar input toolbar, which are already in HTML for the Inspector. So, can you clarify what work will be done?
Flags: needinfo?(gl) → needinfo?(gasolin)

Comment 10

2 years ago
Thanks for update, my plan is only convert the inspector main search box (from xul textbox to html:input) in bug 1265759, so its not affect the sidebar input toolbar.
Flags: needinfo?(gasolin)

Updated

2 years ago
No longer blocks: 1265759
(Reporter)

Updated

2 years ago
Assignee: gl → nobody
Status: ASSIGNED → NEW

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.