1250087 - The value of mute/volume in the nsPIDOMWindow should be as same as AudioChannelConfig's.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: AudioChannel, defect)

Description

[Alastor Wu [:alwu]]

When we change the value of the audioMuted and audioVolume, it should also be applied to the AudioChannelService::AudioChannelConfig.

Both them are related to the same window, so we should make them consistent.

Comment 1

[Alastor Wu [:alwu]]

Hi, Baku,
Should the |winData->mChannels.mVolume| always equal to |window->GetAudioVolume()|?
Thanks!

Comment 2

[Andrea Marchesini [:baku]]

No it's not. the window volume is managed by the window itself or by nsIDOMWindowUtils.
AudioChannelService exposes the volume via BrowserElement API in b2g. These 2 values are multiplied in AudioChannelService::GetState.

Comment 3

[Alastor Wu [:alwu]]

Why we don't treat them as the same value? Is there any use cases we need two different volume values for that window?

Comment 4

[Alastor Wu [:alwu]]

Because most of time the volume of the AudioChannelConfig is 1.0, that means the multiplied result is equal to the window volume.

Therefore, I am thinking about whether we can make them consistent and regard them as the same value.

Comment 5

[Andrea Marchesini [:baku]]

> Therefore, I am thinking about whether we can make them consistent and
> regard them as the same value.

That would mean that nsIDOMWindowUtils and BrowserElement API touch the same value. I don't see good reasons to do that. Same for muted value. But if you want to propose something, I'll review it.

Comment 6

[Alastor Wu [:alwu]]

After rethinking my proposal, it seems no significant benefit to merge these two value together.
Reopen it if we need to do that someday.