125013 - ProcessMultipartFormFields hangs

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P1)

Description

[Thomas Klaeger]

Creating attachments to bugs with Opera 6.0 may lead to hangs in createattachment.cgi

The 
problem is with ProcessMultipartFormFields() and the boundary-string that Opera may send. 
According to RFC2046 the boundary string may contain ()+./? which cause problems with the search 
for boundaries of ProcessMultipartFormFields.

The attached file resolves the problem by 
escaping these special characters.

Comment 1

[Thomas Klaeger]

Attachment: Patch for correcting boundary string matching

Comment 2

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 69033 [details] [diff] [review]
Patch for correcting boundary string matching


Yep, it's a bug, and it still exists on the development tip.
This patch doesn't work with the tip, however, since the
ProcessMultipartFormFields function has been completely
rewritten since 2.14.1.  Provide a new patch for the current
tip and I'll review and check in.


>--- CGI.pl      Sun Dec  9 16:02:46 2001 -0000  1.100.2.1
>+++ CGI.pl      Tue Feb 12 13:28:00 2001 -0000
>@@ -148,5 +148,6 @@
> sub ProcessMultipartFormFields {
>     my ($boundary) = (@_);
>+    $boundary =~ s/(\+|\(|\)|\.|\/|\?)/\\$1/g;

Use \Q to escape meta-characters in the $boundary variable
from within the regular expression itself instead of doing
it manually beforehand, i.e.:

	if ($_ =~ m/^-*\Q$boundary\E/) {

Comment 3

[Thomas Klaeger]

So here is the output from cvs diff:

Index: 
CGI.pl
===================================================================
RCS 
file: /cvsroot/mozilla/webtools/bugzilla/CGI.pl,v
retrieving revision 1.133
diff -w -
r1.133 CGI.pl
192c192
<         if ($_ =~ m/^-*$boundary/) {
---
>         if ($_ =~ m/^-*\Q$boundary\E/) {

Comment 4

[Thomas Klaeger]

Attachment: Patch for correcting boundary string matching (Updated)

Comment 5

[Dave Miller [:justdave]]

Comment on attachment 69455 [details] [diff] [review]
Patch for correcting boundary string matching (Updated)

trivial change, darn obvious.

2xr= justdave

Comment 6

[Dave Miller [:justdave]]

-> patch author

Comment 7

[Dave Miller [:justdave]]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.145; previous revision: 1.144
done