1250187 - Display errors for passcode failures when entering or configuring passcodes

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Description

[Stephan Leroux [:sleroux]]

The passcode screens have been built but currently don't show any errors state. This bug is to add in some visual feedback to the user indicating the error.

Comment 1

[Stephan Leroux [:sleroux]]

Attachment: Simulator Screen Shot Feb 22, 2016, 1.42.27 PM.png

What do you think of this for presenting the error message? Only issue is when rotating to landscape there isn't much room to show the error.

Comment 2

[Robin Andersen [:tecgirl]]

Can we force portrait orientation?

Comment 3

[Stephan Leroux [:sleroux]]

I believe so. I don't see that being a problem to force passcode to be portrait.

Comment 4

[Robin Andersen [:tecgirl]]

Comment on attachment 8722099 [details]
Simulator Screen Shot Feb 22, 2016, 1.42.27 PM.png

I can see how this is better for accessibility, but it's bit dark. Could we match the red and radius of the native error?

See: http://c.tecgirl.com/fEh0
R: 186, G: 32, B: 36
Radius: 40px

Comment 5

[Stephan Leroux [:sleroux]]

I can give that a try. Also I noticed in the new mocks that you use a label instead. Want to do that instead?

Comment 6

[Robin Andersen [:tecgirl]]

:sleroux, I think the above is likely better for accessibility.

Comment 7

[Stephan Leroux [:sleroux]]

Landed with patch for https://github.com/mozilla/firefox-ios/pull/1571

Comment 8

[Stephan Leroux [:sleroux]]

master 6c697ce68692401b4ca6e6b0f4980fde02d7828f