1250234 - WebSocket::CreateAndDispatchMessageEvent can leave stray exceptions on JSContexts

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Say we get into this code.  We set up an AutoJSAPI, then do some stuff like allocate strings and blob buffers and whatnot.  Those things can throw OOM.  And then we just leave it hanging out on the JSContext.

The good news is that we can just take ownership of error reporting on the AutoJSAPI and things will be good.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Make WebSocket::CreateAndDispatchMessageEvent properly report JS exceptions it might be producing

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Could we please make AutoJSAPI less error prone to use when dealing with exceptions. It is guaranteed that we'll forget to use TakeOwnershipOfErrorReporting() when needed.
I think AutoJSAPI ctor or Init should take some non-optional enum value to indicate the exception handling. Or should AutoJSAPI always handle exceptions and then in some special cases one could prevent that?

Comment 3

[Boris Zbarsky [:bzbarsky]]

> Or should AutoJSAPI always handle exceptions and then in some special cases one could prevent that?

That's the plan in general.  That's what bug 1072144 is on the way to, for example.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/96d04f92c8c4

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/96d04f92c8c4